From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] input: remove BKL from uinput open function
Date: Fri, 29 Jan 2010 19:23:16 -0200 [thread overview]
Message-ID: <1264800197-29523-1-git-send-email-cascardo@holoscopio.com> (raw)
Commit 8702965848ed4bee27486a3e3d2ae34ebba6dd83 has push down the BKL
into uinput open function. However, there's nothing that needs locking
in there.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/input/misc/uinput.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index d3f5724..18206e1 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -34,7 +34,6 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/init.h>
-#include <linux/smp_lock.h>
#include <linux/fs.h>
#include <linux/miscdevice.h>
#include <linux/uinput.h>
@@ -284,7 +283,6 @@ static int uinput_open(struct inode *inode, struct file *file)
if (!newdev)
return -ENOMEM;
- lock_kernel();
mutex_init(&newdev->mutex);
spin_lock_init(&newdev->requests_lock);
init_waitqueue_head(&newdev->requests_waitq);
@@ -292,7 +290,6 @@ static int uinput_open(struct inode *inode, struct file *file)
newdev->state = UIST_NEW_DEVICE;
file->private_data = newdev;
- unlock_kernel();
return 0;
}
--
1.6.6
next reply other threads:[~2010-01-29 21:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 21:23 Thadeu Lima de Souza Cascardo [this message]
2010-01-30 6:41 ` Arnd Bergmann
2010-01-30 7:22 ` Dmitry Torokhov
2010-01-30 21:57 ` Arnd Bergmann
2010-01-30 23:07 ` John Kacur
2010-01-31 4:20 ` Arnd Bergmann
2010-01-31 5:29 ` Dmitry Torokhov
2010-02-01 20:22 ` John Kacur
2010-02-01 20:27 ` John Kacur
2010-02-01 20:46 ` Thadeu Lima de Souza Cascardo
2010-02-01 21:04 ` John Kacur
2010-02-01 21:21 ` Dmitry Torokhov
2010-02-01 21:50 ` John Kacur
2010-02-01 22:08 ` Dmitry Torokhov
2010-02-01 23:18 ` John Kacur
2010-02-03 5:07 ` Dmitry Torokhov
2010-02-04 7:32 ` Arnd Bergmann
2010-02-05 16:04 ` John Kacur
2010-01-30 7:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264800197-29523-1-git-send-email-cascardo@holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®