From: Joe Perches <joe@perches.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-kernel@vger.kernel.org,
Roger Lucas <vt8231@hiddenengine.co.uk>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 04/10] drivers/hwmon/vt8231.c: Fix continuation line formats
Date: Tue, 02 Feb 2010 00:01:07 -0800 [thread overview]
Message-ID: <1265097667.25140.786.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100202085651.360fed29@hyperion.delvare>
On Tue, 2010-02-02 at 08:56 +0100, Jean Delvare wrote:
> > diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
> > index d47b4c9..e6078c9 100644
> > --- a/drivers/hwmon/vt8231.c
> > +++ b/drivers/hwmon/vt8231.c
> > @@ -948,8 +948,7 @@ static int __devinit vt8231_pci_probe(struct pci_dev *dev,
> >
> > address = val & ~(VT8231_EXTENT - 1);
> > if (address == 0) {
> > - dev_err(&dev->dev, "base address not set -\
> > - upgrade BIOS or use force_addr=0xaddr\n");
> > + dev_err(&dev->dev, "base address not set - upgrade BIOS or use force_addr=0xaddr\n");
> > return -ENODEV;
> > }
> >
>
> Good catch, and thanks for the fix. But now we have an overlong line,
> which checkpatch will complain about. So I would prefer if you'd fix
> the problem by replacing the \ by a pair of ".
That depends on what version of checkpatch you're using.
There's one with a pr_<level> and dev_<level> exemption
to the long line check.
next prev parent reply other threads:[~2010-02-02 8:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1265095093.git.joe@perches.com>
2010-02-02 7:22 ` [PATCH 01/10] arch/ia64: " Joe Perches
2010-02-07 11:43 ` Avi Kivity
2010-02-02 7:22 ` [PATCH 02/10] drivers/ata: " Joe Perches
2010-02-03 17:21 ` Mark Lord
2010-02-03 17:25 ` Jeff Garzik
2010-02-03 19:15 ` Joe Perches
2010-02-04 1:39 ` Krzysztof Halasa
2010-02-04 3:36 ` Joe Perches
2010-02-04 4:59 ` Mark Lord
2010-02-04 5:13 ` Andrew Morton
2010-02-04 14:03 ` Mark Lord
2010-02-04 5:16 ` Joe Perches
2010-02-04 14:07 ` Mark Lord
2010-02-02 7:22 ` [PATCH 03/10] drivers/gpu/drm/i915/intel_bios.c: " Joe Perches
2010-02-02 7:22 ` [PATCH 04/10] drivers/hwmon/vt8231.c: " Joe Perches
2010-02-02 7:56 ` [lm-sensors] " Jean Delvare
2010-02-02 8:01 ` Joe Perches [this message]
2010-02-02 7:22 ` [PATCH 05/10] drivers/net/davinci_emac.c: " Joe Perches
2010-02-02 7:22 ` [PATCH 06/10] drivers/scsi/qla2xxx/qua_os.c: " Joe Perches
2010-02-02 7:22 ` [PATCH 07/10] drivers/spi/spi_s3c64xx.c: " Joe Perches
2010-02-02 8:21 ` Grant Likely
2010-02-02 7:22 ` [PATCH 08/10] drivers/staging: " Joe Perches
2010-02-02 7:22 ` [PATCH 09/10] drivers/video/via: " Joe Perches
2010-02-03 22:36 ` Florian Tobias Schandinat
2010-02-02 7:22 ` [PATCH 10/10] sound/soc/s3c24xx/s2c-pcm.c: " Joe Perches
2010-02-02 11:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265097667.25140.786.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=vt8231@hiddenengine.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®