From: Ben Hutchings <bhutchings@solarflare.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Kevin Pedretti <ktpedre@sandia.gov>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seastar - SeaStar Ethernet driver
Date: Tue, 02 Feb 2010 22:12:41 +0000 [thread overview]
Message-ID: <1265148761.2622.10.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <4B68A03E.1010403@xenotime.net>
On Tue, 2010-02-02 at 13:59 -0800, Randy Dunlap wrote:
> On 02/02/10 12:58, Kevin Pedretti wrote:
[...]
> > +static void seastar_map_host_region(struct ss_priv *ssp, const void *addr)
> > +{
> > + /* Round addr to the nearest 128 MB */
> > + unsigned long raw_paddr = __pa(addr);
> > + unsigned long paddr = raw_paddr& ~((1<< 28) - 1);
> > +
> > + htb_map[8] = 0x8000 | ((paddr>> 28) + 0);
> > + htb_map[9] = 0x8000 | ((paddr>> 28) + 1);
>
> space before <<, &, and >>
[...]
The spacing looked correct here.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-02-02 22:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 20:58 Kevin Pedretti
2010-02-02 21:42 ` David Miller
2010-02-03 1:24 ` Kevin Pedretti
2010-02-03 1:40 ` David Miller
2010-02-03 1:41 ` David Miller
2010-02-04 23:01 ` Kevin Pedretti
2010-02-04 23:13 ` David Miller
2010-02-05 0:36 ` Kevin Pedretti
2010-02-05 1:04 ` David Miller
2010-02-04 23:16 ` Alan Cox
2010-02-05 0:59 ` Kevin Pedretti
2010-02-03 16:12 ` Randy Dunlap
2010-02-02 21:59 ` Randy Dunlap
2010-02-02 22:12 ` Ben Hutchings [this message]
2010-02-02 23:38 ` Stephen Hemminger
2010-02-03 1:08 ` [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) Kevin Pedretti
2010-02-03 1:39 ` Stephen Hemminger
2010-02-03 2:02 ` Joe Perches
2010-02-03 2:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265148761.2622.10.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=ktpedre@sandia.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome