From: Joe Perches <joe@perches.com>
To: Greg KH <greg@kroah.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/usb: Convert concatenated __FILE__ to %s, __FILE__
Date: Mon, 08 Feb 2010 14:47:11 -0800 [thread overview]
Message-ID: <1265669231.2135.12.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100208044917.GC30314@kroah.com>
On Sun, 2010-02-07 at 20:49 -0800, Greg KH wrote:
> On Fri, Feb 05, 2010 at 05:51:13PM -0800, Joe Perches wrote:
> > Reduces string space a bit
> It does? Does gcc optimize all of the __FILE__ instances to point to
> the same place in the object?
Yes, just like any other duplicated const string.
Converting a source unit with a single use of __FILE__
wastes space (direct string vs pointer + "%s" + string)
Multiple conversions generally save space.
prev parent reply other threads:[~2010-02-08 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 1:51 Joe Perches
2010-02-08 4:49 ` Greg KH
2010-02-08 22:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265669231.2135.12.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®