From: Ian Campbell <Ian.Campbell@citrix.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
Keir Fraser <Keir.Fraser@eu.citrix.com>,
xen-devel <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] xen: Make event channel work with PV featured HVM
Date: Tue, 9 Feb 2010 11:52:56 +0000 [thread overview]
Message-ID: <1265716376.24394.32669.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1265616354-7384-6-git-send-email-sheng@linux.intel.com>
On Mon, 2010-02-08 at 08:05 +0000, Sheng Yang wrote:
> + if (xen_hvm_pv_evtchn_enabled()) {
> + if (enable_hvm_pv(HVM_PV_EVTCHN))
> + return -EINVAL;
> +[...]
> + callback_via = HVM_CALLBACK_VECTOR(X86_PLATFORM_IPI_VECTOR);
> + set_callback_via(callback_via);
> +
> + x86_platform_ipi_callback = do_hvm_pv_evtchn_intr;
Why this indirection via X86_PLATFORM_IPI_VECTOR?
Apart from that why not use CALLBACKOP_register subop CALLBACKTYPE_event
pointing to xen_hypervisor_callback the same as a full PV guest?
This would remove all the evtchn related code from HVMOP_enable_pv which
I think should be eventually unnecessary as an independent hypercall
since all HVM guests should simply be PV capable by default -- the
hypervisor only needs to track if the guest has made use of specific PV
functionality, not the umbrella "is PV" state.
Ian.
next prev parent reply other threads:[~2010-02-09 11:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 8:05 [PATCH 0/7][v3] PV featured HVM(Hybrid) for Xen Sheng Yang
2010-02-08 8:05 ` [PATCH 1/7] xen: add support for hvm_op Sheng Yang
2010-02-08 8:05 ` [PATCH 2/7] xen: Import cpuid.h from Xen Sheng Yang
2010-02-08 8:05 ` [PATCH 3/7] xen/hvm: Xen PV featured HVM initialization Sheng Yang
2010-02-08 8:05 ` [PATCH 4/7] xen: The entrance for PV featured HVM Sheng Yang
2010-02-08 8:05 ` [PATCH 5/7] xen: Make event channel work with " Sheng Yang
2010-02-09 11:52 ` Ian Campbell [this message]
2010-02-09 12:46 ` Sheng Yang
2010-02-09 14:02 ` [Xen-devel] " Ian Campbell
2010-02-09 17:17 ` Sheng Yang
2010-02-09 18:01 ` Stefano Stabellini
2010-02-11 9:59 ` Sheng Yang
2010-02-12 11:59 ` [Xen-devel] Re: [PATCH 5/7] xen: Make event channel work with PV featured HVe Stefano Stabellini
2010-02-10 3:16 ` [Xen-devel] Re: [PATCH 5/7] xen: Make event channel work with PV featured HVM Nakajima, Jun
2010-02-10 10:20 ` Ian Campbell
2010-02-11 9:59 ` Sheng Yang
2010-02-09 12:51 ` [Xen-devel] " Stefano Stabellini
2010-02-08 8:05 ` [PATCH 6/7] xen: Unified checking for Xen of PV drivers to xenbus_register_frontend() Sheng Yang
2010-02-08 8:05 ` [PATCH 7/7] xen: Enable grant table and xenbus Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265716376.24394.32669.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®