From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553Ab0BJNRj (ORCPT ); Wed, 10 Feb 2010 08:17:39 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:52222 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087Ab0BJNRi (ORCPT ); Wed, 10 Feb 2010 08:17:38 -0500 Subject: Re: [PATCH] perf_events: AMD event scheduling (v3) From: Peter Zijlstra To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org, davem@davemloft.net, fweisbec@gmail.com, robert.richter@amd.com, perfmon2-devel@lists.sf.net, eranian@gmail.com In-Reply-To: References: <4b703957.0702d00a.6bf2.7b7d@mx.google.com> <1265803166.11509.286.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Wed, 10 Feb 2010 14:17:10 +0100 Message-ID: <1265807830.11509.295.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-02-10 at 14:04 +0100, Stephane Eranian wrote: > > @@ -2268,7 +2268,7 @@ static inline int amd_is_nb_event(struct > > u64 val = hwc->config & K7_EVNTSEL_EVENT_MASK; > > /* event code : bits [35-32] | [7-0] */ > > val = (val >> 24) | (val & 0xff); > > - return val >= 0x0e0; > > + return val >= 0xe00; > > } > > > I don't understand the change from 0xe0 to 0xe00. > That's not the same thing at all. > Event select is bits 0-7 + 32-35. OK that appears to be my bad, because you extended K7_EVNTSEL_EVENT_MASK with bit 35 I thought NB events all had bit 35 set. But looking at the AMD docs it does indeed appear to start at 0xe0, and there are no events with bit 35 set, only a few with bit 32. I'll switch it back to 0xe0.