mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: kgdb-bugreport@lists.sourceforge.net, mingo@elte.hu,
	Jason Wessel <jason.wessel@windriver.com>,
	David Airlie <airlied@linux.ie>
Subject: [PATCH 4/7] i915: when kgdb is active display compression should be off
Date: Fri, 12 Feb 2010 16:36:25 -0600	[thread overview]
Message-ID: <1266014188-29505-5-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1266014188-29505-1-git-send-email-jason.wessel@windriver.com>

If the HW compression is left on, the call backs from the HW will
crash the kernel.  The only time this code is called is when kernel
mode setting is in use with kgdb and the kdb shell.

The atomic display pipe handler callback will reset everything when
kgdb restores kernel to the run state.

CC: David Airlie <airlied@linux.ie>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 drivers/gpu/drm/i915/intel_display.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 088b8bd..21e9597 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1210,6 +1210,10 @@ static void intel_update_fbc(struct drm_crtc *crtc,
 		goto out_disable;
 	}
 
+	/* If the kernel debugger is active, always disable compression */
+	if (in_dbg_master())
+		goto out_disable;
+
 	if (dev_priv->display.fbc_enabled(crtc)) {
 		/* We can re-enable it in this case, but need to update pitch */
 		if (fb->pitch > dev_priv->cfb_pitch)
-- 
1.6.4.rc1


  parent reply	other threads:[~2010-02-12 22:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12 22:36 [PATCH 0/7] kms + kgdb & kdb proposed merge for 2.6.34 Jason Wessel
2010-02-12 22:36 ` [PATCH 1/7] kgdboc,debug_core: Add call backs to allow kernel mode switching Jason Wessel
2010-02-25 16:37   ` Jesse Barnes
2010-02-12 22:36 ` [PATCH 2/7] drm: add KGDB/KDB support Add support for KDB entry/exit Jason Wessel
2010-02-12 22:36 ` [PATCH 3/7] kms,kdb: Force unblank a console device Jason Wessel
2010-02-25 16:39   ` Jesse Barnes
2010-02-12 22:36 ` Jason Wessel [this message]
2010-02-12 22:36 ` [PATCH 5/7] drm_fb_helper: Preserve capability to use atomic kms Jason Wessel
2010-02-12 22:36 ` [PATCH 6/7] kgdb,docs: Update the kgdb docs to include kms Jason Wessel
2010-02-12 23:05   ` Randy Dunlap
2010-02-17 22:01     ` [Kgdb-bugreport] " Jason Wessel
2010-02-12 22:36 ` [PATCH 7/7] RFC,HACK,EXPERIMENTAL,drm,i915 - atomic mutex HACKS Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266014188-29505-5-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=airlied@linux.ie \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®