From: Johannes Berg <johannes@sipsolutions.net>
To: rostedt@goodmis.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][trace-cmd] parse-events: Make input buffer const char *
Date: Sat, 13 Feb 2010 12:22:01 +0100 [thread overview]
Message-ID: <1266060121.3753.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1266022384.24271.106.camel@gandalf.stny.rr.com>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Fri, 2010-02-12 at 19:53 -0500, Steven Rostedt wrote:
> I just wanted you to see a recent change I made. It touches your work
> around you added for the older kernels that did not convert your macro
> to a string. I'm sending this to you to make sure that it still works
> for your liking.
Heh, that means I'd have to test it? :)
> Also, I think I see a bug in the original code (and I kept) where you
> added a \ to %s. Perhaps its not a bug, but is it really needed? We
> don't process this code through any printf formatting.
Looks like a typo.
Patch _looks_ good otherwise, I'll give it a try when I find a file or
get one from a user.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2010-02-13 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 0:53 Steven Rostedt
2010-02-13 11:22 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266060121.3753.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome