mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	James Morris <jmorris@namei.org>,
	linux-kernel@vger.kernel.org, Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH] vfs: don't call ima_file_check() unconditionally in nfsd_open()
Date: Tue, 16 Feb 2010 09:33:22 -0500	[thread overview]
Message-ID: <1266330802.4416.9.camel@dyn9002018117.watson.ibm.com> (raw)
In-Reply-To: <201002152307.o1FN7f10019719@int-mx02.intmail.prod.int.phx2.redhat.com>

On Mon, 2010-02-15 at 18:07 -0500, Chuck Ebbert wrote:
> From: Chuck Ebbert <cebbert@redhat.com>
> 
> vfs: don't call ima_file_check() unconditionally in nfsd_open()
> 
> commit 1e41568d7378d1ba8c64ba137b9ddd00b59f893a ("Take ima_path_check()
> in nfsd past dentry_open() in nfsd_open()") moved this code back to its
> original location but missed the "else".
> 
> Signed-off-by: Chuck Ebbert <cebbert@redhat.com>

Thanks for catching it.

Signed-off-by: Mimi Zohar <zohar@us.ibm.com>

> --- linux-2.6.32.noarch.orig/fs/nfsd/vfs.c
> +++ linux-2.6.32.noarch/fs/nfsd/vfs.c
> @@ -752,7 +752,8 @@ nfsd_open(struct svc_rqst *rqstp, struct
>  			    flags, current_cred());
>  	if (IS_ERR(*filp))
>  		host_err = PTR_ERR(*filp);
> -	host_err = ima_file_check(*filp, access);
> +	else
> +		host_err = ima_file_check(*filp, access);
>  out_nfserr:
>  	err = nfserrno(host_err);
>  out:


      reply	other threads:[~2010-02-16 14:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 23:07 Chuck Ebbert
2010-02-16 14:33 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266330802.4416.9.camel@dyn9002018117.watson.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=cebbert@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®