From: Luca Barbieri <luca@luca-barbieri.com>
To: mingo@elte.hu
Cc: hpa@zytor.com, a.p.zijlstra@chello.nl, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
Luca Barbieri <luca@luca-barbieri.com>
Subject: [PATCH 01/10] x86: add support for multiple choice alternatives
Date: Wed, 17 Feb 2010 12:42:33 +0100 [thread overview]
Message-ID: <1266406962-17463-2-git-send-email-luca@luca-barbieri.com> (raw)
In-Reply-To: <1266406962-17463-1-git-send-email-luca@luca-barbieri.com>
This patch modifies the x86 alternative macros to allow more than one
alternative code sequence.
This is done by simply adding multiple alternative patches, which are
applied in sequence, overwriting previous ones.
Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
---
arch/x86/include/asm/alternative.h | 27 ++++++++++++++++++++-------
1 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h
index 69b74a7..42d41ac 100644
--- a/arch/x86/include/asm/alternative.h
+++ b/arch/x86/include/asm/alternative.h
@@ -73,23 +73,36 @@ static inline void alternatives_smp_module_del(struct module *mod) {}
static inline void alternatives_smp_switch(int smp) {}
#endif /* CONFIG_SMP */
-/* alternative assembly primitive: */
-#define ALTERNATIVE(oldinstr, newinstr, feature) \
- \
- "661:\n\t" oldinstr "\n662:\n" \
+#define ALTERNATIVE_PATCH(oldstart, oldend, newinstr, feature) \
".section .altinstructions,\"a\"\n" \
_ASM_ALIGN "\n" \
- _ASM_PTR "661b\n" /* label */ \
+ _ASM_PTR oldstart "\n" /* label */ \
_ASM_PTR "663f\n" /* new instruction */ \
" .byte " __stringify(feature) "\n" /* feature bit */ \
- " .byte 662b-661b\n" /* sourcelen */ \
+ " .byte (" oldend ")-(" oldstart ")\n" /* sourcelen */ \
" .byte 664f-663f\n" /* replacementlen */ \
- " .byte 0xff + (664f-663f) - (662b-661b)\n" /* rlen <= slen */ \
+ " .byte 0xff + (664f-663f) - ((" oldend ")-(" oldstart "))\n" /* rlen <= slen */ \
".previous\n" \
".section .altinstr_replacement, \"ax\"\n" \
"663:\n\t" newinstr "\n664:\n" /* replacement */ \
".previous"
+/* alternative assembly primitive: */
+#define ALTERNATIVE(oldinstr, newinstr, feature) \
+ "661:\n\t" oldinstr "\n662:\n" \
+ ALTERNATIVE_PATCH("661b", "662b", newinstr, feature)
+
+#define ALTERNATIVE3(oldinstr, newinstr1, feature1, newinstr2, feature2) \
+ "661:\n\t" oldinstr "\n662:\n" \
+ ALTERNATIVE_PATCH("661b", "662b", newinstr1, feature1) "\n" \
+ ALTERNATIVE_PATCH("661b", "662b", newinstr2, feature2)
+
+#define ALTERNATIVE4(oldinstr, newinstr1, feature1, newinstr2, feature2, newinstr3, feature3) \
+ "661:\n\t" oldinstr "\n662:\n" \
+ ALTERNATIVE_PATCH("661b", "662b", newinstr1, feature1) "\n" \
+ ALTERNATIVE_PATCH("661b", "662b", newinstr2, feature2) "\n" \
+ ALTERNATIVE_PATCH("661b", "662b", newinstr3, feature3)
+
/*
* Alternative instructions for different CPU types or capabilities.
*
--
1.6.6.1.476.g01ddb
next prev parent reply other threads:[~2010-02-17 11:42 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 11:42 [PATCH 0/10] x86-32: improve atomic64_t functions Luca Barbieri
2010-02-17 11:42 ` Luca Barbieri [this message]
2010-02-17 12:47 ` [PATCH 01/10] x86: add support for multiple choice alternatives Avi Kivity
2010-02-18 19:46 ` H. Peter Anvin
2010-02-17 11:42 ` [PATCH 02/10] x86: add support for relative CALL and JMP in alternatives Luca Barbieri
2010-02-18 19:40 ` H. Peter Anvin
2010-02-18 23:38 ` Luca Barbieri
2010-02-18 23:54 ` H. Peter Anvin
2010-02-19 14:27 ` Masami Hiramatsu
2010-02-17 11:42 ` [PATCH 03/10] x86: add support for lock prefix " Luca Barbieri
2010-02-17 11:42 ` [PATCH 04/10] x86-32: allow UP/SMP lock replacement in cmpxchg64 Luca Barbieri
2010-02-17 11:42 ` [PATCH 05/10] lib: add self-test for atomic64_t Luca Barbieri
2010-02-17 11:42 ` [PATCH 06/10] x86-32: rewrite 32-bit atomic64 functions in assembly Luca Barbieri
2010-02-17 11:42 ` [PATCH 07/10] lib: move generic atomic64 to atomic64-impl.h Luca Barbieri
2010-02-17 11:42 ` [PATCH 08/10] x86-32: support atomic64_t on 386/486 UP/SMP Luca Barbieri
2010-02-18 10:25 ` Peter Zijlstra
2010-02-18 10:58 ` Luca Barbieri
2010-02-18 15:20 ` H. Peter Anvin
2010-02-17 11:42 ` [PATCH 09/10] x86-32: use SSE for atomic64_read/set if available Luca Barbieri
2010-02-17 22:39 ` H. Peter Anvin
2010-02-18 0:41 ` Luca Barbieri
2010-02-18 0:47 ` H. Peter Anvin
2010-02-18 9:56 ` Avi Kivity
2010-02-18 10:07 ` Luca Barbieri
2010-02-18 8:23 ` Andi Kleen
2010-02-18 9:53 ` Luca Barbieri
2010-02-18 9:56 ` Luca Barbieri
2010-02-18 10:11 ` Andi Kleen
2010-02-18 10:27 ` Luca Barbieri
2010-02-18 15:24 ` H. Peter Anvin
2010-02-18 18:14 ` Luca Barbieri
2010-02-18 18:28 ` H. Peter Anvin
2010-02-18 18:42 ` Luca Barbieri
2010-02-18 19:07 ` H. Peter Anvin
2010-02-18 20:26 ` Andi Kleen
2010-02-18 16:52 ` H. Peter Anvin
2010-02-18 18:49 ` Luca Barbieri
2010-02-18 19:06 ` H. Peter Anvin
2010-02-18 19:43 ` Luca Barbieri
2010-02-18 19:45 ` Yuhong Bao
2010-02-18 10:24 ` Peter Zijlstra
2010-02-18 10:25 ` Peter Zijlstra
2010-02-18 10:50 ` Luca Barbieri
2010-02-18 11:00 ` Peter Zijlstra
2010-02-18 12:29 ` Luca Barbieri
2010-02-18 12:32 ` Peter Zijlstra
2010-02-18 13:45 ` Luca Barbieri
2010-02-17 11:42 ` [PATCH 10/10] x86-32: panic on !CX8 && XMM Luca Barbieri
2010-02-17 22:38 ` H. Peter Anvin
2010-02-17 23:00 ` Yuhong Bao
2010-02-17 23:41 ` H. Peter Anvin
2010-02-18 1:13 ` Yuhong Bao
2010-02-25 20:24 ` Yuhong Bao
2010-02-18 0:46 ` Luca Barbieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266406962-17463-2-git-send-email-luca@luca-barbieri.com \
--to=luca@luca-barbieri.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®