mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 09/10] KVM: SVM: Make lazy FPU switching work with nested svm
Date: Thu, 18 Feb 2010 12:38:34 +0100	[thread overview]
Message-ID: <1266493115-28386-10-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1266493115-28386-1-git-send-email-joerg.roedel@amd.com>

TDB.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kvm/svm.c |   43 +++++++++++++++++++++++++++++++++++++++----
 1 files changed, 39 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index a64b871..ad419aa 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -973,6 +973,7 @@ static void svm_decache_cr4_guest_bits(struct kvm_vcpu *vcpu)
 
 static void update_cr0_intercept(struct vcpu_svm *svm)
 {
+	struct vmcb *vmcb = svm->vmcb;
 	ulong gcr0 = svm->vcpu.arch.cr0;
 	u64 *hcr0 = &svm->vmcb->save.cr0;
 
@@ -984,11 +985,25 @@ static void update_cr0_intercept(struct vcpu_svm *svm)
 
 
 	if (gcr0 == *hcr0 && svm->vcpu.fpu_active) {
-		svm->vmcb->control.intercept_cr_read &= ~INTERCEPT_CR0_MASK;
-		svm->vmcb->control.intercept_cr_write &= ~INTERCEPT_CR0_MASK;
+		vmcb->control.intercept_cr_read &= ~INTERCEPT_CR0_MASK;
+		vmcb->control.intercept_cr_write &= ~INTERCEPT_CR0_MASK;
+		if (is_nested(svm)) {
+			struct vmcb *hsave = svm->nested.hsave;
+
+			hsave->control.intercept_cr_read  &= ~INTERCEPT_CR0_MASK;
+			hsave->control.intercept_cr_write &= ~INTERCEPT_CR0_MASK;
+			vmcb->control.intercept_cr_read  |= svm->nested.intercept_cr_read;
+			vmcb->control.intercept_cr_write |= svm->nested.intercept_cr_write;
+		}
 	} else {
 		svm->vmcb->control.intercept_cr_read |= INTERCEPT_CR0_MASK;
 		svm->vmcb->control.intercept_cr_write |= INTERCEPT_CR0_MASK;
+		if (is_nested(svm)) {
+			struct vmcb *hsave = svm->nested.hsave;
+
+			hsave->control.intercept_cr_read |= INTERCEPT_CR0_MASK;
+			hsave->control.intercept_cr_write |= INTERCEPT_CR0_MASK;
+		}
 	}
 }
 
@@ -1263,7 +1278,22 @@ static int ud_interception(struct vcpu_svm *svm)
 static void svm_fpu_activate(struct kvm_vcpu *vcpu)
 {
 	struct vcpu_svm *svm = to_svm(vcpu);
-	svm->vmcb->control.intercept_exceptions &= ~(1 << NM_VECTOR);
+	u32 excp;
+
+	if (is_nested(svm)) {
+		u32 h_excp, n_excp;
+
+		h_excp  = svm->nested.hsave->control.intercept_exceptions;
+		n_excp  = svm->nested.intercept_exceptions;
+		h_excp &= ~(1 << NM_VECTOR);
+		excp    = h_excp | n_excp;
+	} else {
+		excp  = svm->vmcb->control.intercept_exceptions;
+	        excp &= ~(1 << NM_VECTOR);
+	}
+
+	svm->vmcb->control.intercept_exceptions = excp;
+
 	svm->vcpu.fpu_active = 1;
 	update_cr0_intercept(svm);
 }
@@ -1507,6 +1537,9 @@ static int nested_svm_exit_special(struct vcpu_svm *svm)
 		if (!npt_enabled)
 			return NESTED_EXIT_HOST;
 		break;
+	case SVM_EXIT_EXCP_BASE + NM_VECTOR:
+		nm_interception(svm);
+		break;
 	default:
 		break;
 	}
@@ -2972,8 +3005,10 @@ static void svm_fpu_deactivate(struct kvm_vcpu *vcpu)
 {
 	struct vcpu_svm *svm = to_svm(vcpu);
 
-	update_cr0_intercept(svm);
 	svm->vmcb->control.intercept_exceptions |= 1 << NM_VECTOR;
+	if (is_nested(svm))
+		svm->nested.hsave->control.intercept_exceptions |= 1 << NM_VECTOR;
+	update_cr0_intercept(svm);
 }
 
 static struct kvm_x86_ops svm_x86_ops = {
-- 
1.6.6



  parent reply	other threads:[~2010-02-18 11:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 11:38 [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Joerg Roedel
2010-02-18 11:38 ` [PATCH 01/10] KVM: SVM: Don't use kmap_atomic in nested_svm_map Joerg Roedel
2010-02-18 13:40   ` Avi Kivity
2010-02-18 16:16     ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 02/10] KVM: SVM: Fix wrong interrupt injection in enable_irq_windows Joerg Roedel
2010-02-18 11:38 ` [PATCH 03/10] KVM: SVM: Fix schedule-while-atomic on nested exception handling Joerg Roedel
2010-02-18 13:52   ` Avi Kivity
2010-02-18 16:24     ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 04/10] KVM: SVM: Sync all control registers on nested vmexit Joerg Roedel
2010-02-18 11:38 ` [PATCH 05/10] KVM: SVM: Annotate nested_svm_map with might_sleep() Joerg Roedel
2010-02-18 11:38 ` [PATCH 06/10] KVM: SVM: Fix nested msr intercept handling Joerg Roedel
2010-02-18 11:38 ` [PATCH 07/10] KVM: SVM: Don't sync nested cr8 to lapic and back Joerg Roedel
2010-02-18 11:38 ` [PATCH 08/10] KVM: SVM: Activate nested state only when guest state is complete Joerg Roedel
2010-02-18 11:38 ` Joerg Roedel [this message]
2010-02-18 14:32   ` [PATCH 09/10] KVM: SVM: Make lazy FPU switching work with nested svm Avi Kivity
2010-02-18 16:29     ` Joerg Roedel
2010-02-18 14:51   ` Alexander Graf
2010-02-18 14:55     ` Avi Kivity
2010-02-18 16:30       ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 10/10] KVM: SVM: Remove newlines from nested trace points Joerg Roedel
2010-02-18 14:33 ` [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Avi Kivity
2010-02-18 14:48   ` Alexander Graf
2010-02-18 14:54     ` Avi Kivity
2010-02-18 16:33       ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266493115-28386-10-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome