From: Joe Perches <joe@perches.com>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: printk_ratelimited() not compiling
Date: Thu, 18 Feb 2010 15:23:39 -0800 [thread overview]
Message-ID: <1266535419.8446.320.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1266532567.3201.97.camel@localhost.localdomain>
On Thu, 2010-02-18 at 14:36 -0800, john stultz wrote:
> > Am I missing something obvious, or did something get broken after this went in?
> Ok. Solved it. I needed to #include <linux/ratelimit.h> in the file I
> was adding the printk_ratelimited usage in, rather then where
> printk_ratelimited is defined.
>
> Maybe would it be better to move the printk_ratelimited definitions into
> ratelimit.h so this would be more obvious?
That's one option.
Probably the only places I tried it had an
#include <linux/net.h> somewhere which does an
#include <linux/ratelimit.h>
Personally, I think it'd be better to put
#include <linux/ratelimit.h> back in kernel.h
Commit 3fff4c42bd0a89869a0eb1e7874cc06ffa4aa0f5 removed it.
next prev parent reply other threads:[~2010-02-18 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 22:10 john stultz
2010-02-18 22:28 ` Joe Perches
2010-02-18 22:36 ` john stultz
2010-02-18 23:23 ` Joe Perches [this message]
2010-02-18 23:33 ` john stultz
2010-02-18 23:49 ` john stultz
2010-02-19 0:15 ` [RFC PATCH] printk_ratelimited: Move definitions to ratelimit.h, use DEFINE_RATELIMIT_STATE Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266535419.8446.320.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®