From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] get_maintainer: use references and closures
Date: Fri, 19 Feb 2010 08:08:06 -0800 [thread overview]
Message-ID: <1266595686.8446.737.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100219070130.781454971@vyatta.com>
On Thu, 2010-02-18 at 23:01 -0800, Stephen Hemminger wrote:
> if (!$printed_novcs) {
> - warn("$P: No supported VCS found. Add --nogit to options?\n");
> - warn("Using a git repository produces better results.\n");
> - warn("Try Linus Torvalds' latest git repository using:\n");
> - warn("git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n");
> + warn "$P: No supported VCS found. Add --nogit to options?\n",
> + "Using a git repository produces better results.\n",
> + "Try Linus Torvalds' latest git repository using:\n",
> + "git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n";
> $printed_novcs = 1;
All other quoted string line continuations use periods.
Please use periods and resubmit.
next prev parent reply other threads:[~2010-02-20 2:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 7:01 [PATCH 0/3] Get maintainer script cleanups Stephen Hemminger
2010-02-19 7:01 ` [PATCH 1/3] get_maintainer: fix perlcritic warnings Stephen Hemminger
2010-02-19 16:07 ` Joe Perches
2010-02-19 7:01 ` [PATCH 2/3] get_maintainer: use references and closures Stephen Hemminger
2010-02-19 16:08 ` Joe Perches [this message]
2010-02-19 7:01 ` [PATCH 3/3] get_maintainer: quote email address with period Stephen Hemminger
2010-02-19 16:08 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266595686.8446.737.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®