From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Neil Horman <nhorman@tuxdriver.com>,
Vivek Goyal <vgoyal@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Tom Zanussi <tzanussi@gmail.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Simon Kagstrom <simon.kagstrom@netinsight.net>,
David Woodhouse <David.Woodhouse@intel.com>,
Markus Metzger <markus.t.metzger@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/06] kernel.h tracing stuff cleanup
Date: Mon, 22 Feb 2010 09:36:06 -0500 [thread overview]
Message-ID: <1266849367.24271.4386.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20100222142008.GA9032@darkstar>
On Mon, 2010-02-22 at 22:20 +0800, Dave Young wrote:
> trace stuff in kernel.h should stay in their own head file
>
> cleanup trace declarations in kernel.h, put them into ring_buffer.h
> include ring_buffer.h in every file which need it
NAK, sorry.
1) it does not belong in ring_buffer.h. The ring buffer.h is for the
ring buffer only, and is agnostic to other tracing code.
2) trace_prink() and friends needs to be with printk. It is not used
much in the delivered kernel but it is used often in development. That
is, we purposely made it so it is not needed to add a header file to
everyplace you use trace_prink(). When debugging a problem,
trace_printk() needs to be as convenient as adding printk(), and by
needing to find "what header includes trace_printk()" will become an
overwhelming inconvenience.
-- Steve
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
prev parent reply other threads:[~2010-02-22 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 14:20 Dave Young
2010-02-22 14:36 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266849367.24271.4386.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=David.Woodhouse@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
--cc=simon.kagstrom@netinsight.net \
--cc=tzanussi@gmail.com \
--cc=vegard.nossum@gmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®