From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Tom Zanussi <tzanussi@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Keiichi KII <k-keiichi@bx.jp.nec.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 01/10] perf/scripts: Fix supported language listing option
Date: Thu, 25 Feb 2010 04:42:32 +0100 [thread overview]
Message-ID: <1267069361-10909-2-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1267069361-10909-1-git-send-regression-fweisbec@gmail.com>
From: Tom Zanussi <tzanussi@gmail.com>
'perf trace -s list' prints a list of the supported scripting
languages. One problem with it is that it falls through and prints
the trace as well. The use of 'list' for this also makes it easy to
confuse with 'perf trace -l', used for listing available scripts. So
change 'perf trace -s list' to 'perf trace -s lang' and fixes the
fall-through problem.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Keiichi KII <k-keiichi@bx.jp.nec.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1264580883-15324-2-git-send-email-tzanussi@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
tools/perf/Documentation/perf-trace.txt | 4 +++-
tools/perf/builtin-trace.c | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt
index 60e5900..c00a76f 100644
--- a/tools/perf/Documentation/perf-trace.txt
+++ b/tools/perf/Documentation/perf-trace.txt
@@ -45,9 +45,11 @@ OPTIONS
--list=::
Display a list of available trace scripts.
--s::
+-s ['lang']::
--script=::
Process trace data with the given script ([lang]:script[.ext]).
+ If the string 'lang' is specified in place of a script name, a
+ list of supported languages will be displayed instead.
-g::
--gen-script=::
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 0b65779..d5d20c3 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -219,9 +219,9 @@ static int parse_scriptname(const struct option *opt __used,
const char *script, *ext;
int len;
- if (strcmp(str, "list") == 0) {
+ if (strcmp(str, "lang") == 0) {
list_available_languages();
- return 0;
+ exit(0);
}
script = strchr(str, ':');
--
1.6.2.3
next prev parent reply other threads:[~2010-02-25 3:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 3:42 [GIT PULL] Perf python scripting support Frederic Weisbecker
2010-02-25 3:42 ` Frederic Weisbecker [this message]
2010-02-25 3:42 ` [PATCH 02/10] perf/scripts: Fix bug in Util.pm Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 03/10] perf/scripts: Move common code out of Perl-specific files Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 04/10] perf/scripts: Move Perl scripting files to scripting-engines dir Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 05/10] perf/scripts: Remove check-perf-trace from listed scripts Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 06/10] perf/scripts: Add Python scripting engine Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 07/10] perf/scripts: Add syscall tracing scripts Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 08/10] perf/scripts: Remove unnecessary PyTuple resizes Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 09/10] perf/scripts: Add perf-trace-python Documentation Frederic Weisbecker
2010-02-25 3:42 ` [PATCH 10/10] perf/scripts: Tag syscall_name helper as not yet available Frederic Weisbecker
2010-02-25 7:32 ` [GIT PULL] Perf python scripting support Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267069361-10909-2-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®