From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 3/5] KVM: SVM: Use svm_msrpm_offset in nested_svm_exit_handled_msr
Date: Thu, 25 Feb 2010 18:15:47 +0100 [thread overview]
Message-ID: <1267118149-15737-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1267118149-15737-1-git-send-email-joerg.roedel@amd.com>
There is a generic function now to calculate msrpm offsets.
Use that function in nested_svm_exit_handled_msr() remove
the duplicate logic.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kvm/svm.c | 44 ++++++++++++++------------------------------
1 files changed, 14 insertions(+), 30 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index d15e0ea..bb75a44 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1605,40 +1605,24 @@ static void nested_svm_unmap(struct page *page)
static bool nested_svm_exit_handled_msr(struct vcpu_svm *svm)
{
- u32 param = svm->vmcb->control.exit_info_1 & 1;
- u32 msr = svm->vcpu.arch.regs[VCPU_REGS_RCX];
- bool ret = false;
- u32 t0, t1;
- u8 val;
+ u32 offset, msr, value;
+ int write, mask;
- if (!(svm->nested.intercept & (1ULL << INTERCEPT_MSR_PROT)))
- return false;
+ msr = svm->vcpu.arch.regs[VCPU_REGS_RCX];
+ offset = svm_msrpm_offset(msr);
+ write = svm->vmcb->control.exit_info_1 & 1;
+ mask = 1 << ((2 * (msr & 0xf)) + write);
- switch (msr) {
- case 0 ... 0x1fff:
- t0 = (msr * 2) % 8;
- t1 = msr / 8;
- break;
- case 0xc0000000 ... 0xc0001fff:
- t0 = (8192 + msr - 0xc0000000) * 2;
- t1 = (t0 / 8);
- t0 %= 8;
- break;
- case 0xc0010000 ... 0xc0011fff:
- t0 = (16384 + msr - 0xc0010000) * 2;
- t1 = (t0 / 8);
- t0 %= 8;
- break;
- default:
- ret = true;
- goto out;
- }
+ if (offset == MSR_INVALID)
+ return NESTED_EXIT_DONE;
- if (!kvm_read_guest(svm->vcpu.kvm, svm->nested.vmcb_msrpm + t1, &val, 1))
- ret = val & ((1 << param) << t0);
+ /* Offset is in 32 bit units but need in 8 bit units */
+ offset = svm->nested.vmcb_msrpm + (offset * 4);
-out:
- return ret;
+ if (kvm_read_guest(svm->vcpu.kvm, offset, &value, 4))
+ return NESTED_EXIT_DONE;
+
+ return (value & mask) ? NESTED_EXIT_DONE : NESTED_EXIT_HOST;
}
static int nested_svm_exit_special(struct vcpu_svm *svm)
--
1.7.0
next prev parent reply other threads:[~2010-02-25 17:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 17:15 [PATCH 0/5] Rework of msrpm optimization and additional fixes for nested svm Joerg Roedel
2010-02-25 17:15 ` [PATCH 1/5] KVM: SVM: Move msrpm offset calculation to seperate function Joerg Roedel
2010-02-26 10:20 ` Avi Kivity
2010-02-26 10:25 ` Joerg Roedel
2010-02-25 17:15 ` [PATCH 2/5] KVM: SVM: Optimize nested svm msrpm merging Joerg Roedel
2010-02-26 10:28 ` Avi Kivity
2010-02-26 12:25 ` Joerg Roedel
2010-02-26 12:28 ` Alexander Graf
2010-02-26 13:04 ` Joerg Roedel
2010-02-26 13:08 ` Alexander Graf
2010-02-26 13:19 ` Joerg Roedel
2010-02-26 13:10 ` Avi Kivity
2010-02-26 13:21 ` Joerg Roedel
2010-02-26 13:26 ` Alexander Graf
2010-02-26 13:30 ` Joerg Roedel
2010-02-26 13:59 ` Avi Kivity
2010-02-26 12:42 ` Avi Kivity
2010-02-25 17:15 ` Joerg Roedel [this message]
2010-02-26 10:30 ` [PATCH 3/5] KVM: SVM: Use svm_msrpm_offset in nested_svm_exit_handled_msr Avi Kivity
2010-03-01 13:33 ` Joerg Roedel
2010-02-25 17:15 ` [PATCH 4/5] KVM: SVM: Add correct handling of nested iopm Joerg Roedel
2010-02-26 10:33 ` Avi Kivity
2010-02-25 17:15 ` [PATCH 5/5] KVM: SVM: Ignore lower 12 bit of nested msrpm_pa Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267118149-15737-4-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®