From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][trace-cmd] trace-record: wrong refferencing
Date: Thu, 25 Feb 2010 12:56:12 -0500 [thread overview]
Message-ID: <1267120572.6328.22.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1267119647-16775-1-git-send-email-jolsa@redhat.com>
On Thu, 2010-02-25 at 18:40 +0100, Jiri Olsa wrote:
> hi,
>
> looks like bug this time :)
Indeed it is.
Applied, thanks!
-- Steve
>
> wbr,
> jirka
>
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> diff --git a/trace-record.c b/trace-record.c
> index cdfc857..2a754b9 100644
> --- a/trace-record.c
> +++ b/trace-record.c
> @@ -116,7 +116,7 @@ struct tracecmd_recorder *tracecmd_create_recorder(const char *file, int cpu)
> int fd;
>
> fd = open(file, O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
> - if (recorder->fd < 0)
> + if (fd < 0)
> return NULL;
>
> recorder = tracecmd_create_recorder_fd(fd, cpu);
prev parent reply other threads:[~2010-02-25 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 17:40 Jiri Olsa
2010-02-25 17:56 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267120572.6328.22.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®