From: "Steven J. Magnani" <steve@digidescorp.com>
To: linux-kernel@vger.kernel.org
Cc: microblaze-uclinux@itee.uq.edu.au, dan.j.williams@intel.com
Subject: Buggy variable-length array code...or compiler?
Date: Thu, 25 Feb 2010 17:17:29 -0600 [thread overview]
Message-ID: <1267139849.3079.68.camel@iscandar.digidescorp.com> (raw)
When I run a memcpy dmatest with a Microblaze 2.6.33 noMMU kernel, the
system crashes after about 400 iterations. After much head scratching, I
believe I've narrowed the problem to this fragment of code in
drivers/dma/dmatest.c:
static int dmatest_func(void *data)
{
struct dmatest_thread *thread = data;
...
unsigned int total_tests = 0;
int src_cnt;
int dst_cnt;
...
if (thread->type == DMA_MEMCPY)
src_cnt = dst_cnt = 1;
...
while (!kthread_should_stop()
&& !(iterations && total_tests >= iterations)) {
struct dma_device *dev = chan->device;
struct dma_async_tx_descriptor *tx = NULL;
dma_addr_t dma_srcs[src_cnt];
dma_addr_t dma_dsts[dst_cnt];
...
total_tests++;
/* CODE ADDED BY ME FOR DEBUG */
printk("dmatest: Iteration %d, dma_srcs = %p\n",
total_tests, dma_srcs);
...
}
With this code I get output like this:
dmatest: Iteration 1, dma_srcs = 2c963ee8
dmatest: Iteration 2, dma_srcs = 2c963ed8
dmatest: Iteration 3, dma_srcs = 2c963ec8
dmatest: Iteration 4, dma_srcs = 2c963eb8
...
dmatest: Iteration 420, dma_srcs = 2c9624b8
...and then the stack detonates and the kernel crashes with some strange
error or other.
Are there any language lawyers in the house who'd care to weigh in on
which of these possibilities is the right one?
1. There is a coding error in dmatest
2. There is a bug specific to Microblaze gcc compiler(s) [mine is 4.1.2]
3. There is a bug generic to specific versions of gcc compilers
4. There is a bug generic to all gcc compilers
Obviously, the options get more disturbing the higher you go. I don't
know if VLAs are used elsewhere in the kernel; a 'smatch' search might
be helpful.
Regards,
------------------------------------------------------------------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
next reply other threads:[~2010-02-25 23:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 23:17 Steven J. Magnani [this message]
2010-02-25 23:23 ` Samuel Thibault
2010-02-25 23:46 ` David Rientjes
2010-02-26 10:27 ` Dan Carpenter
2010-02-26 19:15 ` Steven J. Magnani
2010-02-26 19:43 ` Dan Williams
2010-02-26 0:46 ` J.A. Magallón
2010-02-26 17:43 ` Samuel Thibault
2010-02-26 18:52 ` Steven J. Magnani
2010-02-26 10:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267139849.3079.68.camel@iscandar.digidescorp.com \
--to=steve@digidescorp.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®