From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
oprofile-list <oprofile-list@lists.sourceforge.net>,
Robert Richter <robert.richter@amd.com>
Subject: [PATCH 14/15] perf, x86: add some IBS macros to perf_event.h
Date: Fri, 26 Feb 2010 18:30:06 +0100 [thread overview]
Message-ID: <1267205407-6523-15-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1267205407-6523-1-git-send-email-robert.richter@amd.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
arch/x86/include/asm/perf_event.h | 4 +++-
arch/x86/oprofile/op_model_amd.c | 6 +++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
index 4745f65..237c3d9 100644
--- a/arch/x86/include/asm/perf_event.h
+++ b/arch/x86/include/asm/perf_event.h
@@ -109,12 +109,14 @@ union cpuid10_edx {
#define IBS_FETCH_RAND_EN (1ULL<<57)
#define IBS_FETCH_VAL (1ULL<<49)
#define IBS_FETCH_ENABLE (1ULL<<48)
-#define IBS_FETCH_CNT_MASK 0xFFFF0000ULL
+#define IBS_FETCH_CNT 0xFFFF0000ULL
+#define IBS_FETCH_MAX_CNT 0x0000FFFFULL
/* IbsOpCtl bits */
#define IBS_OP_CNT_CTL (1ULL<<19)
#define IBS_OP_VAL (1ULL<<18)
#define IBS_OP_ENABLE (1ULL<<17)
+#define IBS_OP_MAX_CNT 0x0000FFFFULL
#ifdef CONFIG_PERF_EVENTS
extern void init_hw_perf_events(void);
diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c
index c671749..8ddb9fa 100644
--- a/arch/x86/oprofile/op_model_amd.c
+++ b/arch/x86/oprofile/op_model_amd.c
@@ -279,7 +279,7 @@ op_amd_handle_ibs(struct pt_regs * const regs,
oprofile_write_commit(&entry);
/* reenable the IRQ */
- ctl &= ~(IBS_FETCH_VAL | IBS_FETCH_CNT_MASK);
+ ctl &= ~(IBS_FETCH_VAL | IBS_FETCH_CNT);
ctl |= IBS_FETCH_ENABLE;
wrmsrl(MSR_AMD64_IBSFETCHCTL, ctl);
}
@@ -319,7 +319,7 @@ static inline void op_amd_start_ibs(void)
return;
if (ibs_config.fetch_enabled) {
- val = (ibs_config.max_cnt_fetch >> 4) & 0xFFFF;
+ val = (ibs_config.max_cnt_fetch >> 4) & IBS_FETCH_MAX_CNT;
val |= ibs_config.rand_en ? IBS_FETCH_RAND_EN : 0;
val |= IBS_FETCH_ENABLE;
wrmsrl(MSR_AMD64_IBSFETCHCTL, val);
@@ -341,7 +341,7 @@ static inline void op_amd_start_ibs(void)
* avoid underflows.
*/
ibs_op_ctl = min(ibs_op_ctl + IBS_RANDOM_MAXCNT_OFFSET,
- 0xFFFFULL);
+ IBS_OP_MAX_CNT);
}
if (ibs_caps & IBS_CAPS_OPCNT && ibs_config.dispatched_ops)
ibs_op_ctl |= IBS_OP_CNT_CTL;
--
1.6.6
next prev parent reply other threads:[~2010-02-26 17:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 17:29 [PATCH 00/15] oprofile fixes and updates for v2.6.34 Robert Richter
2010-02-26 17:29 ` [PATCH 01/15] oprofile: remove tracing build dependency Robert Richter
2010-02-26 17:29 ` [PATCH 02/15] oprofile: remove EXPERIMENTAL from the config option description Robert Richter
2010-02-26 17:29 ` [PATCH 03/15] oprofile/x86: remove OPROFILE_IBS config option Robert Richter
2010-02-26 17:29 ` [PATCH 04/15] oprofile/x86: remove node check in AMD IBS initialization Robert Richter
2010-02-26 17:29 ` [PATCH 05/15] oprofile/x86: implement IBS cpuid feature detection Robert Richter
2010-02-26 17:29 ` [PATCH 06/15] oprofile/x86: implement lsfr pseudo-random number generator for IBS Robert Richter
2010-02-26 17:29 ` [PATCH 07/15] oprofile/x86: implement randomization for IBS periodic op counter Robert Richter
2010-02-26 17:30 ` [PATCH 08/15] oprofile/x86: warn user if a counter is already active Robert Richter
2010-02-26 17:30 ` [PATCH 09/15] oprofile/x86: add comment to counter-in-use warning Robert Richter
2010-02-26 17:30 ` [PATCH 10/15] oprofile/x86: fix perfctr nmi reservation for mulitplexing Robert Richter
2010-02-26 17:30 ` [PATCH 11/15] oprofile/x86: use kzalloc() instead of kmalloc() Robert Richter
2010-02-26 17:30 ` [PATCH 12/15] oprofile/x86: fix msr access to reserved counters Robert Richter
2010-02-26 17:30 ` [PATCH 13/15] perf, x86: make IBS macros available in perf_event.h Robert Richter
2010-02-26 17:30 ` Robert Richter [this message]
2010-02-26 17:30 ` [PATCH 15/15] perf, x86: rename macro in ARCH_PERFMON_EVENTSEL_ENABLE Robert Richter
2010-02-27 9:03 ` [PATCH 00/15] oprofile fixes and updates for v2.6.34 Ingo Molnar
2010-03-01 14:39 ` Robert Richter
2010-03-02 10:01 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267205407-6523-15-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome