From: Joerg Roedel <joerg.roedel@amd.com>
To: iommu@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Julia Lawall <julia@diku.dk>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 1/4] x86/amd-iommu: Remove double NULL check in check_device
Date: Mon, 1 Mar 2010 14:24:39 +0100 [thread overview]
Message-ID: <1267449882-1415-2-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1267449882-1415-1-git-send-email-joerg.roedel@amd.com>
From: Julia Lawall <julia@diku.dk>
dev was tested just above, so drop the second test.
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kernel/amd_iommu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index adb0ba0..2c4a501 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -118,7 +118,7 @@ static bool check_device(struct device *dev)
return false;
/* No device or no PCI device */
- if (!dev || dev->bus != &pci_bus_type)
+ if (dev->bus != &pci_bus_type)
return false;
devid = get_device_id(dev);
--
1.7.0
next prev parent reply other threads:[~2010-03-01 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 13:24 [PATCH 0/4] AMD IOMMU fixes for 2.6.34 Joerg Roedel
2010-03-01 13:24 ` Joerg Roedel [this message]
2010-03-01 13:24 ` [PATCH 2/4] x86/amd-iommu: Protect IOMMU-API map/unmap path Joerg Roedel
2010-03-01 13:24 ` [PATCH 3/4] x86/amd-iommu: Pt mode fix for domain_destroy Joerg Roedel
2010-03-01 13:24 ` [PATCH 4/4] x86/amd-iommu: Report errors in acpi parsing functions upstream Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267449882-1415-2-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®