From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714Ab0CARP1 (ORCPT ); Mon, 1 Mar 2010 12:15:27 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:11116 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412Ab0CARPJ (ORCPT ); Mon, 1 Mar 2010 12:15:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; b=RyrzYMUKGUl0FiQP7w6ZrnrJqwmge+htm6Sa2IYZQfxtgYGyfOjTNidUf8BOrM9U4Y jmplb5aNu+t0f00iRrKuUGpRlJrTZBYoRv/7Aj6TThIhfjd2Bqm+rsE+IU4nTrkCT9g9 NWk9LitDPcPa/8quk7zhwQKgUL4JT6j8OV13U= From: Luca Barbieri To: hpa@zytor.com Cc: mingo@elte.hu, a.p.zijlstra@chello.nl, paulus@samba.org, linux-kernel@vger.kernel.org, Luca Barbieri Subject: [PATCH 3/3] lib: fix atomic64_add_unless return value convention Date: Mon, 1 Mar 2010 18:15:00 +0100 Message-Id: <1267463700-25524-4-git-send-email-luca@luca-barbieri.com> X-Mailer: git-send-email 1.6.6.1.476.g01ddb In-Reply-To: <1267463700-25524-1-git-send-email-luca@luca-barbieri.com> References: <1267463700-25524-1-git-send-email-luca@luca-barbieri.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 0 and 1 return values were incorrectly swapped. Reported-by: H. Peter Anvin Signed-off-by: Luca Barbieri --- lib/atomic64.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/atomic64.c b/lib/atomic64.c index 8bee16e..a21c12b 100644 --- a/lib/atomic64.c +++ b/lib/atomic64.c @@ -162,12 +162,12 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u) { unsigned long flags; spinlock_t *lock = lock_addr(v); - int ret = 1; + int ret = 0; spin_lock_irqsave(lock, flags); if (v->counter != u) { v->counter += a; - ret = 0; + ret = 1; } spin_unlock_irqrestore(lock, flags); return ret; -- 1.6.6.1.476.g01ddb