From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <borislav.petkov@amd.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] x86/cpu changes for v2.6.34
Date: Mon, 01 Mar 2010 17:23:43 -0500 [thread overview]
Message-ID: <1267482223.10871.19.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1267472522.10871.14.camel@gandalf.stny.rr.com>
On Mon, 2010-03-01 at 14:42 -0500, Steven Rostedt wrote:
> As Frederic has said you can use 'ftrace=function_graph' on the kernel
> command line. It will be initialized in early_initcall (which I believe
> is before CPUs are set up. Then add a tracing_off() after the trouble
> code. You can make the trace buffers bigger with the kernel command
> line:
>
> trace_buf_size=10000000
>
> The above will make the trace buffer 10Meg per CPU. Unlike the
> "buffer_size_kb" file, this number is in bytes, even though it will
> round to the nearest page. (I probably should make this into kb, and
> rename it to trace_buf_size_kb, and deprecate trace_buf_size).
>
> Then you can cat out /debug/tracing/trace, and search for large
> latencies in the timestamps.
I just tried the above and it doesn't work. The ring buffer gets
allocated with the early_initcall(), so trace_printk()'s will work. But
the function and function graph tracers don't get registered until the
device_initcall().
If you are still interested, this patch will allow you to run the
function graph tracer before smp_init(). You still need to add
"ftrace=function_graph" on the kernel command line.
It's a hack, but I tried it out and it worked.
-- Steve
diff --git a/init/main.c b/init/main.c
index 4cb47a1..b334663 100644
--- a/init/main.c
+++ b/init/main.c
@@ -868,8 +868,15 @@ static int __init kernel_init(void * unused)
do_pre_smp_initcalls();
start_boot_trace();
+ {
+ int init_graph_trace(void);
+ init_graph_trace();
+ }
+ trace_printk("start\n");
smp_init();
sched_init_smp();
+ trace_printk("end\n");
+ tracing_off();
do_basic_setup();
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index aaf580c..f18cad8 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -1214,11 +1214,11 @@ static struct tracer graph_trace __read_mostly = {
#endif
};
-static __init int init_graph_trace(void)
+__init int init_graph_trace(void)
{
max_bytes_for_cpu = snprintf(NULL, 0, "%d", nr_cpu_ids - 1);
return register_tracer(&graph_trace);
}
-device_initcall(init_graph_trace);
+//device_initcall(init_graph_trace);
next prev parent reply other threads:[~2010-03-01 22:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 15:09 Ingo Molnar
2010-02-27 17:10 ` Arjan van de Ven
2010-02-27 20:03 ` H. Peter Anvin
2010-02-28 20:09 ` Linus Torvalds
2010-02-28 20:45 ` Linus Torvalds
2010-03-01 8:00 ` Ingo Molnar
2010-03-01 13:17 ` Frederic Weisbecker
2010-03-01 16:47 ` Linus Torvalds
2010-03-01 19:42 ` Steven Rostedt
2010-03-01 22:23 ` Steven Rostedt [this message]
2010-03-01 22:24 ` H. Peter Anvin
2010-03-01 19:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267482223.10871.19.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®