From: Valdis.Kletnieks@vt.edu
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: linux-next - tty_io.c change breaks /dev/console
Date: Sun, 15 Mar 2009 17:20:04 -0400 [thread overview]
Message-ID: <12675.1237152004@turing-police.cc.vt.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
At boot, all attempts to open /dev/console failed. dmesg shows:
Warning: unable to open an initial console.
from init/main.c:
if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0)
printk(KERN_WARNING "Warning: unable to open an initial console.\n");
problem originally hit in -mmotm, traced down to linux-next.
git bisect of linux-next find this:
31f8326f981117fc548d292656fa8dbed28bc42b is first bad commit
commit 31f8326f981117fc548d292656fa8dbed28bc42b
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu Mar 12 10:00:15 2009 +1100
tty-fix-mismatch-in-lookup-han
The lookup methods return NULL or a pointer. The caller expects an ERR_PTR.
It seems to make sense to just use NULL and return -ENODEV here as it keeps
the code simple and clean and the way it always used to work (effectively)
before the restructure
Problem noticed by Jiri Slaby.
Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
:040000 040000 e6b1ddf54e63b5b7be2bfa07c6a21a9657e91d27 1ef01e18f00a713c3a0299725c6b594da5fcffbe M drivers
Reverting this one commit made things start working again. I admit not
understanding why this commit broke the sys_open().
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
reply other threads:[~2009-03-16 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12675.1237152004@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome