From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413Ab0CBHIA (ORCPT ); Tue, 2 Mar 2010 02:08:00 -0500 Received: from senator.holtmann.net ([87.106.208.187]:50956 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133Ab0CBHH6 (ORCPT ); Tue, 2 Mar 2010 02:07:58 -0500 Subject: Re: linux-next: Tree for March 1 (bluetooth/hci_sysfs) From: Marcel Holtmann To: David Miller Cc: sfr@canb.auug.org.au, randy.dunlap@oracle.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <20100301.181415.266447389.davem@davemloft.net> References: <20100301210210.c6f465e6.sfr@canb.auug.org.au> <4B8C2CC5.8000603@oracle.com> <20100302121526.36a1ea88.sfr@canb.auug.org.au> <20100301.181415.266447389.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 01 Mar 2010 23:06:18 -0800 Message-ID: <1267513578.2710.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 (2.28.2-1.fc12) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, > >> static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf, > >> size_t count, loff_t *ppos) > >> { > >> struct hci_dev *hdev = file->private_data; > >> struct inquiry_cache *cache = &hdev->inq_cache; > >> struct inquiry_entry *e; > >> char buf[4096]; // <<<<<<<<<<<<<<<<<<<<<<<<<<< huh? don't do that on stack. > >> int n = 0; > > > > Dave Miller is following up on that. > > This looks like a job for.... SEQ FILE! :-) > > I'm testing the following fix. the patch looks good, but it doesn't do the job. I have to look into why that is. Will try to come up with a proper patch soon. Regards Marcel