From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754893Ab0CBXuy (ORCPT ); Tue, 2 Mar 2010 18:50:54 -0500 Received: from kroah.org ([198.145.64.141]:51594 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778Ab0CBXg4 (ORCPT ); Tue, 2 Mar 2010 18:36:56 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Roel Kluin , Benjamin Herrenschmidt , Hendrik Brueckner , Christian Borntraeger , Andrew Morton , Greg Kroah-Hartman Subject: [PATCH 14/36] hvc_console: fix test on unsigned in hvc_console_print() Date: Tue, 2 Mar 2010 15:36:21 -0800 Message-Id: <1267573003-782-14-git-send-email-gregkh@suse.de> X-Mailer: git-send-email 1.7.0.1 In-Reply-To: <20100302230956.GC32287@kroah.com> References: <20100302230956.GC32287@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roel Kluin vtermnos[] is unsigned, so this test was wrong. Signed-off-by: Roel Kluin Cc: Benjamin Herrenschmidt Cc: Hendrik Brueckner Cc: Christian Borntraeger Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/char/hvc_console.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c index 4c3b59b..465185f 100644 --- a/drivers/char/hvc_console.c +++ b/drivers/char/hvc_console.c @@ -146,7 +146,7 @@ static void hvc_console_print(struct console *co, const char *b, return; /* This console adapter was removed so it is not usable. */ - if (vtermnos[index] < 0) + if (vtermnos[index] == -1) return; while (count > 0 || i > 0) { -- 1.7.0.1