From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754131Ab0CDDLd (ORCPT ); Wed, 3 Mar 2010 22:11:33 -0500 Received: from e1.ny.us.ibm.com ([32.97.182.141]:35867 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334Ab0CDDL1 (ORCPT ); Wed, 3 Mar 2010 22:11:27 -0500 From: John Stultz To: lkml Cc: John Stultz , Thomas Gleixner , Andrew Morton , Chris Zankel Subject: [PATCH] xtensa: Fix unnecessary setting of xtime Date: Wed, 3 Mar 2010 19:11:20 -0800 Message-Id: <1267672280-21386-3-git-send-email-johnstul@us.ibm.com> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: <1267672280-21386-2-git-send-email-johnstul@us.ibm.com> References: <1267672280-21386-1-git-send-email-johnstul@us.ibm.com> <1267672280-21386-2-git-send-email-johnstul@us.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Not critical, 2.6.35 material. xtensa supports read_persisitent_clock(), so there is no reason for the arch specific code to be setting xtime. Setting xtime will be done by the generic timekeeping code. Please let me know if this is some sort of a workaround for an issue instead of just an oversight. Cc: Thomas Gleixner Cc: Andrew Morton Cc: Chris Zankel Signed-off-by: John Stultz --- arch/xtensa/kernel/time.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/xtensa/kernel/time.c b/arch/xtensa/kernel/time.c index 19f7df3..19df764 100644 --- a/arch/xtensa/kernel/time.c +++ b/arch/xtensa/kernel/time.c @@ -60,11 +60,6 @@ static struct irqaction timer_irqaction = { void __init time_init(void) { - /* FIXME: xtime&wall_to_monotonic are set in timekeeping_init. */ - read_persistent_clock(&xtime); - set_normalized_timespec(&wall_to_monotonic, - -xtime.tv_sec, -xtime.tv_nsec); - #ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT printk("Calibrating CPU frequency "); platform_calibrate_ccount(); -- 1.6.0.4