From: John Stultz <johnstul@us.ibm.com>
To: " lkml" <linux-kernel@vger.kernel.org>
Cc: John Stultz <johnstul@us.ibm.com>,
"David S. Miller\"" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 12/14] sparc: Convert sparc to use read/update_persistent_clock
Date: Wed, 3 Mar 2010 19:57:27 -0800 [thread overview]
Message-ID: <1267675049-12337-13-git-send-email-johnstul@us.ibm.com> (raw)
In-Reply-To: <1267675049-12337-12-git-send-email-johnstul@us.ibm.com>
This patch converts the sparc architecture to use the generic read_persistent_clock and update_persistent_clock interfaces, reducing the amount of arch specific code we have to maintain, and allowing for further cleanups in the future.
I have not built or tested this patch, so help from arch maintainers would be appreciated.
Cc: David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: John Stultz <johnstul@us.ibm.com>
---
arch/sparc/Kconfig | 2 +-
arch/sparc/kernel/time_32.c | 15 +++++----------
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 4097f6a..0e8ec2a 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -72,7 +72,7 @@ config ARCH_USES_GETTIMEOFFSET
config GENERIC_CMOS_UPDATE
bool
- default y if SPARC64
+ default y
config GENERIC_CLOCKEVENTS
bool
diff --git a/arch/sparc/kernel/time_32.c b/arch/sparc/kernel/time_32.c
index 0d4c09b..a3f1690 100644
--- a/arch/sparc/kernel/time_32.c
+++ b/arch/sparc/kernel/time_32.c
@@ -78,6 +78,11 @@ __volatile__ unsigned int *master_l10_counter;
u32 (*do_arch_gettimeoffset)(void);
+int update_persistent_clock(struct timespec now)
+{
+ return set_rtc_mmss(now.tv_sec);
+}
+
/*
* timer_interrupt() needs to keep up the real-time clock,
* as well as call the "do_timer()" routine every clocktick
@@ -101,16 +106,6 @@ static irqreturn_t timer_interrupt(int dummy, void *dev_id)
do_timer(1);
- /* Determine when to update the Mostek clock. */
- if (ntp_synced() &&
- xtime.tv_sec > last_rtc_update + 660 &&
- (xtime.tv_nsec / 1000) >= 500000 - ((unsigned) TICK_SIZE) / 2 &&
- (xtime.tv_nsec / 1000) <= 500000 + ((unsigned) TICK_SIZE) / 2) {
- if (set_rtc_mmss(xtime.tv_sec) == 0)
- last_rtc_update = xtime.tv_sec;
- else
- last_rtc_update = xtime.tv_sec - 600; /* do it again in 60 s */
- }
write_sequnlock(&xtime_lock);
#ifndef CONFIG_SMP
--
1.6.0.4
next prev parent reply other threads:[~2010-03-04 3:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 3:57 [PATCH 00/14] Convert remaining arches " John Stultz
2010-03-04 3:57 ` [PATCH 01/14] alpha: Convert alpha " John Stultz
2010-03-04 3:57 ` [PATCH 02/14] mn10300: Convert mn10300 " John Stultz
2010-03-04 3:57 ` [PATCH 03/14] frv: Convert frv " John Stultz
2010-03-04 3:57 ` [PATCH 04/14] parisc: Convert parisc " John Stultz
2010-03-04 3:57 ` [PATCH 05/14] h8300: Convert h8300 " John Stultz
2010-03-04 3:57 ` [PATCH 06/14] avr32: Convert avr32 " John Stultz
2010-03-04 3:57 ` [PATCH 07/14] ia64: Convert ia64 " John Stultz
2010-03-04 3:57 ` [PATCH 08/14] sh: Convert sh " John Stultz
2010-03-04 3:57 ` [PATCH 09/14] blackfin: Convert blackfin " John Stultz
2010-03-04 3:57 ` [PATCH 10/14] m32r: Convert m32r to use read/update_peristent_clock John Stultz
2010-03-04 3:57 ` [PATCH 11/14] m68k: Convert m68k to use read/update_persistent_clock John Stultz
2010-03-04 3:57 ` John Stultz [this message]
2010-03-04 3:57 ` [PATCH 13/14] cris: Convert cris " John Stultz
2010-03-04 3:57 ` [PATCH 14/14] arm: Convert arm to use read_persistent_clock John Stultz
2010-03-04 9:36 ` Russell King - ARM Linux
2010-03-04 19:55 ` john stultz
2010-03-13 0:21 ` [tip:timers/cleanup] cris: Convert cris to use read/update_persistent_clock tip-bot for John Stultz
2010-03-04 6:41 ` [PATCH 12/14] sparc: Convert sparc " David Miller
2010-03-13 0:21 ` [tip:timers/cleanup] m68k: Convert m68k " tip-bot for John Stultz
2010-03-13 0:21 ` [tip:timers/cleanup] m32r: Convert m32r to use read/update_peristent_clock tip-bot for John Stultz
2010-03-09 23:53 ` [PATCH 09/14] blackfin: Convert blackfin to use read/update_persistent_clock Mike Frysinger
2010-03-09 23:59 ` john stultz
2010-03-10 0:01 ` Mike Frysinger
2010-03-13 0:20 ` [tip:timers/cleanup] " tip-bot for John Stultz
2010-03-04 17:00 ` [PATCH 08/14] sh: Convert sh " Paul Mundt
2010-03-13 0:20 ` [tip:timers/cleanup] ia64: Convert ia64 " tip-bot for John Stultz
2010-03-13 0:20 ` [tip:timers/cleanup] avr32: Convert avr32 " tip-bot for John Stultz
2010-03-13 0:20 ` [tip:timers/cleanup] h8300: Convert h8300 " tip-bot for John Stultz
2010-03-06 22:40 ` [PATCH 04/14] parisc: Convert parisc " Helge Deller
2010-03-06 22:49 ` Kyle McMartin
2010-03-13 0:19 ` [tip:timers/cleanup] frv: Convert frv " tip-bot for John Stultz
2010-03-13 0:19 ` [tip:timers/cleanup] mn10300: Convert mn10300 " tip-bot for John Stultz
2010-03-13 0:19 ` [tip:timers/cleanup] alpha: Convert alpha " tip-bot for John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267675049-12337-13-git-send-email-johnstul@us.ibm.com \
--to=johnstul@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®