From: Joe Perches <joe@perches.com>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Hashir Abdi <habdi@microsoft.com>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH 1/1] Stage: hv: Corrected all header comments to follow kernel-doc format
Date: Thu, 04 Mar 2010 09:55:43 -0800 [thread overview]
Message-ID: <1267725343.12993.20.camel@Joe-Laptop.home> (raw)
In-Reply-To: <8AFC7968D54FB448A30D8F38F259C56217DBFDF9@TK5EX14MBXC116.redmond.corp.microsoft.com>
On Thu, 2010-03-04 at 17:48 +0000, Hank Janssen wrote:
> From: Hank Janssen <hjanssen@microsoft.com>
>
> Removed kerneldoc /** from functions that should not have them.
> Added proper kerneldoc headers to functions that should have them.
> diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c index d46eb14..1fc2710 100644
> --- a/drivers/staging/hv/Channel.c
> +++ b/drivers/staging/hv/Channel.c
> @@ -64,8 +64,9 @@ static void DumpMonitorPage(struct hv_monitor_page *MonitorPage) } #endif
>
> -/**
> - * VmbusChannelSetEvent - Trigger an event notification on the specified channel.
> +/*
> + * VmbusChannelSetEvent - Trigger an event notification on the
> +specified
> + * channel.
> */
> static void VmbusChannelSetEvent(struct vmbus_channel *Channel) { @@ -119,7 +120,7 @@ static void VmbusChannelClearEvent(struct vmbus_channel *channel) }
>
> #endif
Yuck.
I don't know what you used for comment wrapping,
but it's broken here and in a bunch of other places.
Some are shown below:
[]
> -/**
> - * VmbusChannelSendPacketPageBuffer - Send a range of single-page buffer packets using a GPADL Direct packet type.
> +/*
> + * VmbusChannelSendPacketPageBuffer - Send a range of single-page
> +buffer
> + * packets using a GPADL Direct packet type.
> */
> int VmbusChannelSendPacketPageBuffer(struct vmbus_channel *Channel,
> struct hv_page_buffer PageBuffers[], @@ -773,8 +777,9 @@ int VmbusChannelSendPacketPageBuffer(struct vmbus_channel *Channel,
> return ret;
> }
>
> -/**
> - * VmbusChannelSendPacketMultiPageBuffer - Send a multi-page buffer packet using a GPADL Direct packet type.
> +/*
> + * VmbusChannelSendPacketMultiPageBuffer - Send a multi-page buffer
> +packet
> + * using a GPADL Direct packet type.
> */
> int VmbusChannelSendPacketMultiPageBuffer(struct vmbus_channel *Channel,
> struct hv_multipage_buffer *MultiPageBuffer, @@ -842,7 +847,7 @@ int VmbusChannelSendPacketMultiPageBuffer(struct vmbus_channel *Channel,
> return ret;
> }
next prev parent reply other threads:[~2010-03-04 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 20:58 [PATCH 1/1] Stage: hv: Rename struct device_context and re-arrange the fields inside (re-formatted) Haiyang Zhang
2010-02-17 21:05 ` Greg KH
2010-02-17 23:50 ` Greg KH
2010-02-17 23:52 ` Greg KH
2010-02-18 15:51 ` Haiyang Zhang
2010-03-03 16:42 ` Ringbuffer usage in Linux Hyper-V drivers Hank Janssen
2010-03-03 17:49 ` Jeremy Fitzhardinge
2010-03-03 23:39 ` Greg KH
2010-03-04 17:46 ` [PATCH 1/1] Stage: hv: Remove Ringbuffer from TODO line Hank Janssen
2010-03-04 17:48 ` [PATCH 1/1] Stage: hv: Corrected all header comments to follow kernel-doc format Hank Janssen
2010-03-04 17:55 ` Joe Perches [this message]
2010-03-04 18:03 ` Randy Dunlap
2010-03-04 18:11 ` Hank Janssen
2010-03-04 22:11 ` [PATCH 1/1] Stage: hv: Corrected all header comments to follow kernel-doc format-CORRECTED Hank Janssen
2010-03-04 22:37 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267725343.12993.20.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=habdi@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®