From: Mike Galbraith <efault@gmx.de>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.jf.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Yanmin Zhang <yanmin_zhang@linux.jf.intel.com>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [patch 2/2] sched: fix select_idle_sibling() logic in select_task_rq_fair()
Date: Tue, 09 Mar 2010 07:05:49 +0100 [thread overview]
Message-ID: <1268114749.6349.20.camel@marge.simson.net> (raw)
In-Reply-To: <1268087062.2830.285.camel@sbs-t61.sc.intel.com>
On Mon, 2010-03-08 at 14:24 -0800, Suresh Siddha wrote:
> On Fri, 2010-03-05 at 12:25 -0800, Mike Galbraith wrote:
> > On Fri, 2010-03-05 at 10:39 -0800, Suresh Siddha wrote:
> > > plain text document attachment (fix_lat_ctx.patch)
> > > Performance improvements with this patch:
> > > "lat_ctx -s 0 2" ~22usec (before-this-patch) ~5usec (after-this-patch)
> >
> > Hm. On my Q6600 box, it's nowhere near that.
>
> My numbers are based on an atom netbook.
Wish I had an atom to play with, hard to even imagine 22 usec lat_ctx,
that's some _serious_ pain.
> > Calling the waking cpu idle in that case is a mistake. Just because the
> > sync hint was used does not mean there is no gain to be had.
>
> Ok. I dropped that part in v2 patches that I just posted.
Yeah, I see mails (ramble ramble) crossed in the night. I'll take them
out for a spin, see if your box can get fixed up without busting mine :)
-Mike
next prev parent reply other threads:[~2010-03-09 6:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 18:39 [patch 1/2] sched: check for prev_cpu == this_cpu in wake_affine() Suresh Siddha
2010-03-05 18:39 ` [patch 2/2] sched: fix select_idle_sibling() logic in select_task_rq_fair() Suresh Siddha
2010-03-05 20:25 ` Mike Galbraith
2010-03-06 8:21 ` Mike Galbraith
2010-03-08 22:24 ` Suresh Siddha
2010-03-09 6:05 ` Mike Galbraith [this message]
2010-03-09 13:27 ` Mike Galbraith
2010-03-10 21:14 ` Mike Galbraith
2010-03-06 8:36 ` Mike Galbraith
2010-03-05 19:36 ` [patch 1/2] sched: check for prev_cpu == this_cpu in wake_affine() Mike Galbraith
2010-03-08 19:09 ` Suresh Siddha
2010-03-08 22:25 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268114749.6349.20.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.jf.intel.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=yanmin_zhang@linux.jf.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome