From: Jani Nikula <ext-jani.1.nikula@nokia.com>
To: linux-kernel@vger.kernel.org
Cc: sonnyrao@us.ibm.com, benh@kernel.crashing.org,
tklauser@distanz.ch, jkosina@suse.cz,
ext-jani.1.nikula@nokia.com
Subject: [PATCH] powerpc/BSR: fix device_create() return value check
Date: Thu, 11 Mar 2010 18:15:53 +0200 [thread overview]
Message-ID: <1268324153-30345-1-git-send-email-ext-jani.1.nikula@nokia.com> (raw)
From: Jani Nikula <ext-jani.1.nikula@nokia.com>
Use IS_ERR() instead of comparing to NULL.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
---
NOTE: I'm afraid I'm unable to test this; please consider this more a
bug report than a complete patch.
---
drivers/char/bsr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index c02db01..3b31f74 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn)
cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
cur, cur->bsr_name);
- if (!cur->bsr_device) {
+ if (IS_ERR(cur->bsr_device)) {
printk(KERN_ERR "device_create failed for %s\n",
cur->bsr_name);
cdev_del(&cur->bsr_cdev);
--
1.6.5.2
next reply other threads:[~2010-03-11 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 16:15 Jani Nikula [this message]
2010-03-11 21:21 ` Sonny Rao
2010-03-15 14:24 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268324153-30345-1-git-send-email-ext-jani.1.nikula@nokia.com \
--to=ext-jani.1.nikula@nokia.com \
--cc=benh@kernel.crashing.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=sonnyrao@us.ibm.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®