mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Dirk Gouders <dirk@gouders.net>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [RFC v8 1/1] mconf: global i-search in menu prompts
Date: Wed, 20 Jun 2018 13:02:03 -0700	[thread overview]
Message-ID: <126839db-5cc1-7dad-5a1f-21899dc6236e@infradead.org> (raw)
In-Reply-To: <ghpo0l2spo.fsf@lena.gouders.net>

On 06/20/2018 11:55 AM, Dirk Gouders wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> 
>> Hi,
>>
>> On 06/20/2018 01:42 AM, Dirk Gouders wrote:
>>>
>>> Operation
>>> ---------
>>> The TAB key is reserved to toggle the focus between menu and bottons.
>>> Focus is on the buttons if one of the buttens (the active one) is
>>> hightlighted, otherwise it is on the menu.
>>>
>>> When the focus is on the buttons, mconf operates as before with the
>>> exception of the TAB key.
>>>
>>> When the focus is on the menu, mconf operates in i-search mode and the
>>> following input has special meaning:
>>>
>>> * <\> (backslash) can be used to search for other occurences of an
>>>   already entered string.  On empty search strings, nothing happens.
>>>
>>> * Any other printable character than backslash and '\n' is appended to
>>>   the current search string and a match is searched for.  If a match
>>>   is found, it is immediately navigated to.
>>
>> About that paragraph above:  I tried to search for "fs-cache", as in:
>>
>> config FSCACHE_DEBUG
>> 	bool "Debug FS-Cache"
>>
>> but i-search does not allow me to enter a '-' character.  Seems odd to me.
> 
> Hi Randy,
> 
> thanks for all your testing.
> 
> '-' and '+' previously had the same meaning as <KEY_UP>, <KEY_DOWN>,
> respectively.  If you are on the top menu item and press '-' there is
> nothing to scroll up so it appears as if the pressed key wasn't
> processed.
> 
> I-search should add those characters to the pattern but I broke that two
> or three versions before when I fixed another issue.
> 
> I will add this to my list of test cases so this won't happen again.
> 
> Dirk
> 
> 
>> Still doing other testing...

I haven't hit any other issues.

thanks,
-- 
~Randy

  reply	other threads:[~2018-06-20 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  8:42 [RFC v8 0/1] " Dirk Gouders
2018-06-20  8:42 ` [RFC v8 1/1] " Dirk Gouders
2018-06-20 18:21   ` Randy Dunlap
2018-06-20 18:55     ` Dirk Gouders
2018-06-20 20:02       ` Randy Dunlap [this message]
2018-06-21  6:57         ` Dirk Gouders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=126839db-5cc1-7dad-5a1f-21899dc6236e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=dirk@gouders.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=segher@kernel.crashing.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®