From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: thisdyingdream@gmail.com, sjharms@gmail.com,
mcarlson@broadcom.com, mchan@broadcom.com, benli@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sharms@ubuntu.com
Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g
Date: Sat, 13 Mar 2010 12:22:22 -0800 [thread overview]
Message-ID: <1268511742.30289.74.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100313.115555.209991546.davem@davemloft.net>
On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote:
> From: Steven Harms <thisdyingdream@gmail.com>
> Date: Sat, 13 Mar 2010 14:52:26 -0500
>
> > Would you like me to submit the patch adding only the spaces after
> > commas and leave the rest of the defines as is, or discard the changes
> > all together?
>
> I would like you to toss them altogether.
I think that Steven got off on the wrong foot
a bit by adding the parentheses to the defines.
I think the other changes he suggested are
tree-wide style consistency only and are ok.
Perhaps you might reconsider later, after
net-next reopens.
next prev parent reply other threads:[~2010-03-13 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 19:52 Steven Harms
2010-03-13 19:55 ` David Miller
2010-03-13 20:22 ` Joe Perches [this message]
2010-03-15 18:39 ` Matt Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268511742.30289.74.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=benli@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sharms@ubuntu.com \
--cc=sjharms@gmail.com \
--cc=thisdyingdream@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®