From: Jiri Slaby <jslaby@suse.cz>
To: James.Bottomley@suse.de
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, James Smart <james.smart@emulex.com>
Subject: [PATCH 2/3] SCSI: lpfc, fix lock imbalances
Date: Tue, 16 Mar 2010 16:23:58 +0100 [thread overview]
Message-ID: <1268753039-17214-2-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1268753039-17214-1-git-send-email-jslaby@suse.cz>
Stanse found that two error paths in lpfc_bsg_rport_els_cmp and
lpfc_issue_ct_rsp_cmp omits to unlock phba->ct_ev_lock. It is
because they wrongly unlock phba->hbalock instead. Fix that.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: James Smart <james.smart@emulex.com>
Cc: James Bottomley <James.Bottomley@suse.de>
---
drivers/scsi/lpfc/lpfc_bsg.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index 692c29f..992efb1 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -432,7 +432,7 @@ lpfc_bsg_rport_els_cmp(struct lpfc_hba *phba,
dd_data = cmdiocbq->context1;
/* normal completion and timeout crossed paths, already done */
if (!dd_data) {
- spin_unlock_irqrestore(&phba->hbalock, flags);
+ spin_unlock_irqrestore(&phba->ct_ev_lock, flags);
return;
}
@@ -1195,7 +1195,7 @@ lpfc_issue_ct_rsp_cmp(struct lpfc_hba *phba,
dd_data = cmdiocbq->context1;
/* normal completion and timeout crossed paths, already done */
if (!dd_data) {
- spin_unlock_irqrestore(&phba->hbalock, flags);
+ spin_unlock_irqrestore(&phba->ct_ev_lock, flags);
return;
}
--
1.7.0.1
next prev parent reply other threads:[~2010-03-16 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 15:23 [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance Jiri Slaby
2010-03-16 15:23 ` Jiri Slaby [this message]
2010-03-16 17:11 ` [PATCH 2/3] SCSI: lpfc, fix lock imbalances James Smart
2010-03-16 15:23 ` [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance Jiri Slaby
2010-03-16 20:23 ` [Suspected SPAM] " Giridhar Malavali
2010-03-16 18:10 ` [PATCH 1/3] SCSI: be2iscsi, " Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268753039-17214-2-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=James.Bottomley@suse.de \
--cc=james.smart@emulex.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®