mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu
Subject: [PATCH 2/3] kernel.h: fix wrong usage of __ratelimit()
Date: Wed, 17 Mar 2010 10:58:43 +0800	[thread overview]
Message-ID: <1268794724-8665-3-git-send-email-yong.zhang@windriver.com> (raw)
In-Reply-To: <1268794724-8665-1-git-send-email-yong.zhang@windriver.com>

__ratelimit() rerurn 1 means we can go ahead.

Signed-off-by: Yong Zhang <yong.zhang@windriver.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Joe Perches <joe@perches.com>
---
 include/linux/kernel.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 7f07074..9365227 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -426,7 +426,7 @@ static inline char *pack_hex_byte(char *buf, u8 byte)
 		.burst = DEFAULT_RATELIMIT_BURST,       \
 	};                                              \
 							\
-	if (!__ratelimit(&_rs))                         \
+	if (__ratelimit(&_rs))                          \
 		printk(fmt, ##__VA_ARGS__);		\
 })
 #else
-- 
1.6.3.3


  parent reply	other threads:[~2010-03-17  2:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17  2:58 [PATCH 0/3] ratelimit: patchset focus on return value " Yong Zhang
2010-03-17  2:58 ` [PATCH 1/3] ratelimit: annotate ___ratelimit() Yong Zhang
2010-03-17  2:58 ` Yong Zhang [this message]
2010-03-17  2:58 ` [RFC PATCH 3/3] ratelimit: Fix return value when fail to get lock Yong Zhang
2010-03-22 20:07   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268794724-8665-3-git-send-email-yong.zhang@windriver.com \
    --to=yong.zhang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®