From: jsd_syd@yahoo.com.au
To: gregkh@suse.de, wfp5p@virginia.edu, hohndel@infradead.org,
jkosina@suse.cz
Cc: jsd_syd@yahoo.com.au, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Jacob David <jacobselvin@gmail.com>
Subject: [PATCH] Staging: comedi: fixes the checkpatch error in skel.c This is a patch to the skel.c file that fixes the 80 line exceeding warning and the printk warning found by chekpatch.pl tool Signed-off-by: Jacob S David <jacobselvin@gmail.com>
Date: Thu, 18 Mar 2010 02:52:27 +1100 [thread overview]
Message-ID: <1268841147-6185-1-git-send-email-jsd_syd@yahoo.com.au> (raw)
From: Jacob David <jacobselvin@gmail.com>
---
drivers/staging/comedi/drivers/skel.c | 25 ++++++++++++++++---------
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/skel.c b/drivers/staging/comedi/drivers/skel.c
index aba57d9..58658b0 100644
--- a/drivers/staging/comedi/drivers/skel.c
+++ b/drivers/staging/comedi/drivers/skel.c
@@ -130,8 +130,10 @@ MODULE_DEVICE_TABLE(pci, skel_pci_table);
#define thisboard ((const struct skel_board *)dev->board_ptr)
/* this structure is for data unique to this hardware driver. If
- several hardware drivers keep similar information in this structure,
- feel free to suggest moving the variable to the struct comedi_device struct. */
+ * several hardware drivers keep similar information in this structure,
+ * feel free to suggest moving the variable to the struct comedi_device
+ * struct.
+ */
struct skel_private {
int data;
@@ -211,7 +213,7 @@ static int skel_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{
struct comedi_subdevice *s;
- printk("comedi%d: skel: ", dev->minor);
+ printk(KERN_INFO "comedi%d: skel: ", dev->minor);
/*
* If you can probe the device to determine what device in a series
@@ -297,7 +299,7 @@ static int skel_attach(struct comedi_device *dev, struct comedi_devconfig *it)
*/
static int skel_detach(struct comedi_device *dev)
{
- printk("comedi%d: skel: remove\n", dev->minor);
+ printk(KERN_INFO "comedi%d: skel: remove\n", dev->minor);
return 0;
}
@@ -336,7 +338,7 @@ static int skel_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
if (i == TIMEOUT) {
/* printk() should be used instead of printk()
* whenever the code can be called from real-time. */
- printk("timeout\n");
+ printk(KERN_INFO "timeout\n");
return -ETIMEDOUT;
}
@@ -397,7 +399,9 @@ static int skel_ai_cmdtest(struct comedi_device *dev,
if (err)
return 1;
- /* step 2: make sure trigger sources are unique and mutually compatible */
+ /* step 2: make sure trigger sources are unique and mutually
+ * compatible
+ */
/* note that mutual compatibility is not an issue here */
if (cmd->scan_begin_src != TRIG_TIMER &&
@@ -529,7 +533,7 @@ static int skel_ao_winsn(struct comedi_device *dev, struct comedi_subdevice *s,
int i;
int chan = CR_CHAN(insn->chanspec);
- printk("skel_ao_winsn\n");
+ printk(KERN_INFO "skel_ao_winsn\n");
/* Writing a list of values to an AO channel is probably not
* very useful, but that's how the interface is defined. */
for (i = 0; i < insn->n; i++) {
@@ -623,6 +627,9 @@ static int skel_dio_insn_config(struct comedi_device *dev,
* as necessary.
*/
COMEDI_INITCLEANUP(driver_skel);
-/* If you are writing a PCI driver you should use COMEDI_PCI_INITCLEANUP instead.
-*/
+/* If you are writing a PCI driver you should use COMEDI_PCI_INITCLEANUP
+ * instead.
+ */
+
/* COMEDI_PCI_INITCLEANUP(driver_skel, skel_pci_table) */
+
--
1.6.3.3
next reply other threads:[~2010-03-17 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 15:52 jsd_syd [this message]
2010-04-27 22:08 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-03-13 2:51 jsd_syd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268841147-6185-1-git-send-email-jsd_syd@yahoo.com.au \
--to=jsd_syd@yahoo.com.au \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=hohndel@infradead.org \
--cc=jacobselvin@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®