From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673Ab0CRLhV (ORCPT ); Thu, 18 Mar 2010 07:37:21 -0400 Received: from mail1.radix.net ([207.192.128.31]:65230 "EHLO mail1.radix.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000Ab0CRLhS (ORCPT ); Thu, 18 Mar 2010 07:37:18 -0400 Subject: Re: [patch] ivtv: sizeof() => ARRAY_SIZE() From: Andy Walls To: Dan Carpenter Cc: Mauro Carvalho Chehab , ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <20100317151156.GG5331@bicker> References: <20100317151156.GG5331@bicker> Content-Type: text/plain Date: Thu, 18 Mar 2010 07:37:22 -0400 Message-Id: <1268912242.3084.7.camel@palomino.walls.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-2.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-03-17 at 18:11 +0300, Dan Carpenter wrote: > This fixes a smatch warning: > drivers/media/video/ivtv/ivtv-vbi.c +138 ivtv_write_vbi(43) > error: buffer overflow 'vi->cc_payload' 256 <= 1023 > > Signed-off-by: Dan Carpenter Looks good. Reviewed-by: Andy Walls And, if needed Signed-off-by: Andy Walls Regards, Andy > diff --git a/drivers/media/video/ivtv/ivtv-vbi.c b/drivers/media/video/ivtv/ivtv-vbi.c > index f420d31..d73af45 100644 > --- a/drivers/media/video/ivtv/ivtv-vbi.c > +++ b/drivers/media/video/ivtv/ivtv-vbi.c > @@ -134,7 +134,7 @@ void ivtv_write_vbi(struct ivtv *itv, const struct v4l2_sliced_vbi_data *sliced, > } > } > } > - if (found_cc && vi->cc_payload_idx < sizeof(vi->cc_payload)) { > + if (found_cc && vi->cc_payload_idx < ARRAY_SIZE(vi->cc_payload)) { > vi->cc_payload[vi->cc_payload_idx++] = cc; > set_bit(IVTV_F_I_UPDATE_CC, &itv->i_flags); > } >