mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-kernel@vger.kernel.org,
	Richard Kennedy <richard@rsk.demon.co.uk>,
	Johannes Berg <johannes@sipsolutions.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/7] wireless.h: Add STD_IW_HANDLER macro
Date: Thu, 18 Mar 2010 10:37:00 -0700	[thread overview]
Message-ID: <1268933820.2403.25.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1268933005.24544.16.camel@mj>

On Thu, 2010-03-18 at 13:23 -0400, Pavel Roskin wrote:
> On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote:
> > Copied from orinoco, initialize a iw_handler array entry
> > +#define STD_IW_HANDLER(id, func) \
> > +	[IW_IOCTL_IDX(id)] = (iw_handler) func
> Three objections.
> 1) STD_IW_HANDLER is a poor name for a header.  The name should start
> with IW, just like those above and below it.

Is IW_HANDLER ok with you?

> 3) Abstracting a cast is bad unless it's the whole purpose of the macro.
> While Orinoco needs the cast, other drivers may not need it.  Using a
> cast could prevent gcc from finding a legitimate problem.

I've no objection to moving the casts to the uses
of the macro where necessary.


  reply	other threads:[~2010-03-18 17:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  6:21 [PATCH v2 0/7] wireless: Use macros from wireless.h Joe Perches
2010-03-18  6:21 ` [PATCH v2 1/7] wireless.h: Add STD_IW_HANDLER macro Joe Perches
2010-03-18 17:23   ` Pavel Roskin
2010-03-18 17:37     ` Joe Perches [this message]
2010-03-18  6:21 ` [PATCH v2 2/7] net/wireless/wext_core.c: Use IW_IOCTL_IDX macro Joe Perches
2010-03-18  6:21 ` [PATCH v2 3/7] net/wireless/wext-core.c: Use IW_EVENT_IDX macro Joe Perches
2010-03-18  6:21 ` [PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro Joe Perches
2010-03-18 17:25   ` Pavel Roskin
2010-03-18  6:21 ` [PATCH v2 5/7] drivers/net: Remove local #define IW_IOCTL, use STD_IW_HANDLER Joe Perches
2010-03-31 17:55   ` Geoff Levand
2010-03-18  6:21 ` [PATCH v2 6/7] orinoco/wext.c: Remove local #define STD_IW_HANDLER Joe Perches
2010-03-18  6:21 ` [PATCH v2 7/7] wireless.h: Use SIOCIWFIRST not SIOCSIWCOMMIT for range check Joe Perches
2010-03-18 17:12   ` Pavel Roskin
2010-03-18 17:22     ` [PATCH v2 8/7] iw_handler.h: Use SIOCIWFIRST not SIOCSIWCOMMIT for offset comment Joe Perches
2010-03-18 16:21 ` [PATCH v2 0/7] wireless: Use macros from wireless.h Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268933820.2403.25.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=proski@gnu.org \
    --cc=richard@rsk.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®