From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 01/12] sysfs: use sysfs_bin_attr_init in firmware class driver
Date: Fri, 19 Mar 2010 08:18:44 -0700 [thread overview]
Message-ID: <1269011935-8886-1-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20100319151311.GA8541@kroah.com>
From: Jiri Kosina <jkosina@suse.cz>
Annotate dynamic sysfs attribute in fw_setup_device(). This gets
rid of the following lockdep warning:
bnx2 0000:08:00.0: firmware: requesting bnx2/bnx2-mips-06-5.0.0.j6.fw
BUG: key ffff880008293470 not in .data!
------------[ cut here ]------------
WARNING: at kernel/lockdep.c:2706 lockdep_init_map+0x562/0x620()
Modules linked in: bnx2(+) sg tpm_bios floppy rtc_lib usb_storage i2c_piix4 joydev button container shpchp i2c_core sr_mod cdrom pci_hotplug usbhid hid ohci_hcd ehci_hcd sd_mod usbcore edd ext3 mbcache jbd fan ata_generic sata_svw pata_serverworks libata scsi_mod thermal processor
Pid: 1915, comm: work_for_cpu Not tainted 2.6.34-rc1-default #81
Call Trace:
[<ffffffff8107c1d2>] ? lockdep_init_map+0x562/0x620
[<ffffffff81049fd8>] warn_slowpath_common+0x78/0xd0
[<ffffffff8104a03f>] warn_slowpath_null+0xf/0x20
[<ffffffff8107c1d2>] lockdep_init_map+0x562/0x620
[<ffffffff8117a236>] ? sysfs_new_dirent+0x76/0x120
[<ffffffff8126edb2>] ? put_device+0x12/0x20
[<ffffffff811797cc>] sysfs_add_file_mode+0x6c/0xd0
[<ffffffff8117983c>] sysfs_add_file+0xc/0x10
[<ffffffff8117bf61>] sysfs_create_bin_file+0x21/0x30
[<ffffffff81279c61>] _request_firmware+0x2f1/0x650
[<ffffffff8127a04e>] request_firmware+0xe/0x10
[<ffffffffa01ec19e>] bnx2_init_one+0x8f5/0x177e [bnx2]
[<ffffffff81389eab>] ? _raw_spin_unlock_irq+0x2b/0x40
[<ffffffff81040ed9>] ? finish_task_switch+0x69/0x100
[<ffffffff81040e70>] ? finish_task_switch+0x0/0x100
[<ffffffff81064b40>] ? do_work_for_cpu+0x0/0x30
[<ffffffff811e6302>] local_pci_probe+0x12/0x20
[<ffffffff81064b53>] do_work_for_cpu+0x13/0x30
[<ffffffff81064b40>] ? do_work_for_cpu+0x0/0x30
[<ffffffff81068c56>] kthread+0x96/0xa0
[<ffffffff81003e64>] kernel_thread_helper+0x4/0x10
[<ffffffff8138a350>] ? restore_args+0x0/0x30
[<ffffffff81068bc0>] ? kthread+0x0/0xa0
[<ffffffff81003e60>] ? kernel_thread_helper+0x0/0x10
---[ end trace a2ecee9c9602d195 ]---
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/firmware_class.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index d0dc26a..fc7565c 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -442,6 +442,7 @@ static int fw_setup_device(struct firmware *fw, struct device **dev_p,
fw_priv = dev_get_drvdata(f_dev);
fw_priv->fw = fw;
+ sysfs_bin_attr_init(&fw_priv->attr_data);
retval = sysfs_create_bin_file(&f_dev->kobj, &fw_priv->attr_data);
if (retval) {
dev_err(device, "%s: sysfs_create_bin_file failed\n", __func__);
--
1.7.0.2
next prev parent reply other threads:[~2010-03-19 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 15:13 [GIT PATCH] driver core fixes for 2.6.34-git Greg KH
2010-03-19 15:18 ` Greg Kroah-Hartman [this message]
2010-03-19 15:18 ` [PATCH 02/12] sysfs: Initialised pci bus legacy_mem field before use Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 03/12] sysfs: fix sysfs lockdep warning in ipmi code Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 04/12] sysfs: fix sysfs lockdep warning in infiniband code Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 05/12] sysfs: fix sysfs lockdep warning in mlx4 code Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 06/12] Driver core: Early platform kernel-doc update Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 07/12] driver-core: fix missing kernel-doc in firmware_class Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 08/12] kobject: documentation: Fix erroneous example in kobject doc Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 09/12] sysdev: the cpu probe/release attributes should be sysdev_class_attributes Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 10/12] kobject: documentation: Update to refer to kset-example.c Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 11/12] driver-core: document ERR_PTR() return values Greg Kroah-Hartman
2010-03-19 15:18 ` [PATCH 12/12] driver core: numa: fix BUILD_BUG_ON for node_read_distance Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269011935-8886-1-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=ebiederm@xmission.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome