From: David Woodhouse <dwmw2@infradead.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] pci/dmar: Tone down warnings about invalid BIOS DMAR tables
Date: Sun, 21 Mar 2010 08:43:30 +0000 [thread overview]
Message-ID: <1269161010.4028.9824.camel@macbook.infradead.org> (raw)
In-Reply-To: <1269126446.18314.117.camel@localhost>
On Sat, 2010-03-20 at 23:07 +0000, Ben Hutchings wrote:
> We now know how to deal with these tables so that they are harmless.
> Use the TAINT_FIRMWARE_WORKAROUND flag and don't say the BIOS is
> 'broken' as this makes users think of hardware damage.
Nack to the string change. If you see this message, it's because your
BIOS is BROKEN, and this brokenness has caused us to have to disable the
VT-d feature completely. The fuckwits obviously never tested it even as
far as booting a VT-d enabled OS on it even once¹.
We _want_ people to think of it as hardware damage and return the board
to the vendor, as unfit for the purpose for which it was sold.
The rest of the series looks good though; thanks.
I haven't applied the first patch, although it stands alone -- your
other patches will depend on it and cause merge pain. Or do you want me
to take the whole lot through the intel-iommu tree?
--
dwmw2
¹ Or maybe they did, but the OS didn't tell them clearly enough that it
was broken.
next prev parent reply other threads:[~2010-03-21 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 23:01 [PATCH 1/4] pci/dmar: Combine the BIOS DMAR table warning messages Ben Hutchings
2010-03-20 23:05 ` [PATCH 2/4] panic: Allow taint flag for warnings to be changed from TAINT_WARN Ben Hutchings
2010-03-21 19:10 ` Andi Kleen
2010-03-21 19:25 ` Ben Hutchings
2010-03-23 2:47 ` Andrew Morton
2010-03-23 13:20 ` Ben Hutchings
2010-03-23 7:45 ` Paul Mundt
2010-03-23 13:23 ` Ben Hutchings
2010-03-24 11:11 ` Michael Ellerman
2010-03-20 23:06 ` [PATCH 3/4] panic: Add taint flag TAINT_FIRMWARE_WORKAROUND ('I') Ben Hutchings
2010-03-21 1:56 ` Randy Dunlap
2010-03-20 23:07 ` [PATCH 4/4] pci/dmar: Tone down warnings about invalid BIOS DMAR tables Ben Hutchings
2010-03-21 8:43 ` David Woodhouse [this message]
2010-03-21 14:57 ` Ben Hutchings
2010-03-21 15:57 ` David Woodhouse
2010-03-23 2:46 ` [PATCH 1/4] pci/dmar: Combine the BIOS DMAR table warning messages Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269161010.4028.9824.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=ben@decadent.org.uk \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®