From: Lars Lindley <lindley@coyote.org>
To: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi, pavel@ucw.cz
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Lars Lindley <lindley@coyote.org>
Subject: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
Date: Sun, 21 Mar 2010 23:30:58 +0100 [thread overview]
Message-ID: <1269210658-9518-1-git-send-email-lindley@coyote.org> (raw)
I fixed the checkpatch things except a couple of long lines.
I also removed hungarian notation from the argument names
and some "commented away" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
---
drivers/staging/winbond/wb35reg_f.h | 104 ++++++++++++++++++-----------------
1 files changed, 54 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h
index d352bce..1c1e3d8 100644
--- a/drivers/staging/winbond/wb35reg_f.h
+++ b/drivers/staging/winbond/wb35reg_f.h
@@ -3,59 +3,63 @@
#include "wbhal_s.h"
-//====================================
-// Interface function declare
-//====================================
-unsigned char Wb35Reg_initial( struct hw_data * pHwData );
-void Uxx_power_on_procedure( struct hw_data * pHwData );
-void Uxx_power_off_procedure( struct hw_data * pHwData );
-void Uxx_ReadEthernetAddress( struct hw_data * pHwData );
-void Dxx_initial( struct hw_data * pHwData );
-void Mxx_initial( struct hw_data * pHwData );
-void RFSynthesizer_initial( struct hw_data * pHwData );
-//void RFSynthesizer_SwitchingChannel( struct hw_data * pHwData, s8 Channel );
-void RFSynthesizer_SwitchingChannel( struct hw_data * pHwData, struct chan_info Channel );
-void BBProcessor_initial( struct hw_data * pHwData );
-void BBProcessor_RateChanging( struct hw_data * pHwData, u8 rate ); // 20060613.1
-//void RF_RateChanging( struct hw_data * pHwData, u8 rate ); // 20060626.5.c Add
-u8 RFSynthesizer_SetPowerIndex( struct hw_data * pHwData, u8 PowerIndex );
-u8 RFSynthesizer_SetMaxim2828_24Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2828_50Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2827_24Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2827_50Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetMaxim2825Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetAiroha2230Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetAiroha7230Power( struct hw_data *, u8 index );
-u8 RFSynthesizer_SetWinbond242Power( struct hw_data *, u8 index );
-void GetTxVgaFromEEPROM( struct hw_data * pHwData );
-void EEPROMTxVgaAdjust( struct hw_data * pHwData ); // 20060619.5 Add
-
-#define RFWriteControlData( _A, _V ) Wb35Reg_Write( _A, 0x0864, _V )
-
-void Wb35Reg_destroy( struct hw_data * pHwData );
-
-unsigned char Wb35Reg_Read( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterValue );
-unsigned char Wb35Reg_ReadSync( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterValue );
-unsigned char Wb35Reg_Write( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char Wb35Reg_WriteSync( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char Wb35Reg_WriteWithCallbackValue( struct hw_data * pHwData,
- u16 RegisterNo,
- u32 RegisterValue,
- s8 *pValue,
- s8 Len);
-unsigned char Wb35Reg_BurstWrite( struct hw_data * pHwData, u16 RegisterNo, u32 * pRegisterData, u8 NumberOfData, u8 Flag );
-
-void Wb35Reg_EP0VM( struct hw_data * pHwData );
-void Wb35Reg_EP0VM_start( struct hw_data * pHwData );
+/*
+ * ====================================
+ * Interface function declare
+ * ====================================
+ */
+unsigned char Wb35Reg_initial(struct hw_data *HwData);
+void Uxx_power_on_procedure(struct hw_data *HwData);
+void Uxx_power_off_procedure(struct hw_data *HwData);
+void Uxx_ReadEthernetAddress(struct hw_data *HwData);
+void Dxx_initial(struct hw_data *HwData);
+void Mxx_initial(struct hw_data *HwData);
+void RFSynthesizer_initial(struct hw_data *HwData);
+void RFSynthesizer_SwitchingChannel(struct hw_data *HwData, struct chan_info Channel);
+void BBProcessor_initial(struct hw_data *HwData);
+void BBProcessor_RateChanging(struct hw_data *HwData, u8 rate);
+u8 RFSynthesizer_SetPowerIndex(struct hw_data *HwData, u8 PowerIndex);
+u8 RFSynthesizer_SetMaxim2828_24Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2828_50Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2827_24Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2827_50Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetMaxim2825Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetAiroha2230Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetAiroha7230Power(struct hw_data *, u8 index);
+u8 RFSynthesizer_SetWinbond242Power(struct hw_data *, u8 index);
+void GetTxVgaFromEEPROM(struct hw_data *HwData);
+void EEPROMTxVgaAdjust(struct hw_data *HwData);
+
+#define RFWriteControlData(_A, _V) Wb35Reg_Write(_A, 0x0864, _V)
+
+void Wb35Reg_destroy(struct hw_data *HwData);
+
+unsigned char Wb35Reg_Read(struct hw_data *HwData, u16 RegisterNo, u32 *RegisterValue);
+unsigned char Wb35Reg_ReadSync(struct hw_data *HwData, u16 RegisterNo, u32 *RegisterValue);
+unsigned char Wb35Reg_Write(struct hw_data *HwData, u16 RegisterNo, u32 RegisterValue);
+unsigned char Wb35Reg_WriteSync(struct hw_data *HwData, u16 RegisterNo, u32 RegisterValue);
+unsigned char Wb35Reg_WriteWithCallbackValue(struct hw_data *HwData,
+ u16 RegisterNo,
+ u32 RegisterValue,
+ s8 *Value,
+ s8 Len);
+unsigned char Wb35Reg_BurstWrite(struct hw_data *HwData,
+ u16 RegisterNo,
+ u32 *RegisterData,
+ u8 NumberOfData,
+ u8 Flag);
+
+void Wb35Reg_EP0VM(struct hw_data *HwData);
+void Wb35Reg_EP0VM_start(struct hw_data *HwData);
void Wb35Reg_EP0VM_complete(struct urb *urb);
-u32 BitReverse( u32 dwData, u32 DataLength);
+u32 BitReverse(u32 Data, u32 DataLength);
-void CardGetMulticastBit( u8 Address[MAC_ADDR_LENGTH], u8 *Byte, u8 *Value );
-u32 CardComputeCrc( u8 * Buffer, u32 Length );
+void CardGetMulticastBit(u8 Address[MAC_ADDR_LENGTH], u8 *Byte, u8 *Value);
+u32 CardComputeCrc(u8 *Buffer, u32 Length);
-void Wb35Reg_phy_calibration( struct hw_data * pHwData );
-void Wb35Reg_Update( struct hw_data * pHwData, u16 RegisterNo, u32 RegisterValue );
-unsigned char adjust_TXVGA_for_iq_mag( struct hw_data * pHwData );
+void Wb35Reg_phy_calibration(struct hw_data *HwData);
+void Wb35Reg_Update(struct hw_data *HwData, u16 RegisterNo, u32 RegisterValue);
+unsigned char adjust_TXVGA_for_iq_mag(struct hw_data *HwData);
#endif
--
1.7.0.2
next reply other threads:[~2010-03-21 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 22:30 Lars Lindley [this message]
2010-03-22 7:16 ` Pekka Enberg
2010-03-22 9:45 ` Lars Lindley
2010-03-22 9:57 ` Pekka Enberg
2010-03-22 10:55 ` Lars Lindley
2010-03-22 10:56 ` Pekka Enberg
2010-03-22 10:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269210658-9518-1-git-send-email-lindley@coyote.org \
--to=lindley@coyote.org \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®