From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo <mingo@elte.hu>,
paulus@samba.org, davem@davemloft.net, fweisbec@gmail.com,
robert.richter@amd.com, perfmon2-devel@lists.sf.net,
eranian@gmail.com, "hpa@zytor.com" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [PATCH] perf_events: fix bug in AMD per-cpu initialization
Date: Tue, 23 Mar 2010 16:18:26 +0100 [thread overview]
Message-ID: <1269357506.5109.84.camel@twins> (raw)
In-Reply-To: <bd4cb8901003230812s777fcd77x6ffff63123039070@mail.gmail.com>
On Tue, 2010-03-23 at 16:12 +0100, Stephane Eranian wrote:
> On Tue, Mar 23, 2010 at 4:07 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, 2010-03-23 at 15:55 +0100, Stephane Eranian wrote:
> >> What's the point of CPU_ONLINE vs. CPU_STARTING if you're saying the
> >> former is never right? Why not move CPU_ONLINE to the right place and
> >> drop CPU_STARTING?
> >
> > Its right for a lot of things, just not for perf, we need to be ready
> > and done by the time the cpu starts scheduling.
> >
> You mean they need to wait until after the cpu starts scheduling?
> As opposed to being called just before it starts scheduling.
As in it doesn't really matter for them, and the CPU_ONLINE call is
convenient in that it allows the callback to schedule too.
next prev parent reply other threads:[~2010-03-23 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 8:40 Stephane Eranian
2010-03-17 23:47 ` Peter Zijlstra
2010-03-18 0:33 ` Stephane Eranian
2010-03-23 14:11 ` Peter Zijlstra
2010-03-23 14:55 ` Stephane Eranian
2010-03-23 15:07 ` Peter Zijlstra
2010-03-23 15:12 ` Stephane Eranian
2010-03-23 15:18 ` Peter Zijlstra [this message]
2010-03-23 22:41 ` Stephane Eranian
2010-04-02 19:06 ` [tip:perf/core] x86: Move notify_cpu_starting() callback to a later stage tip-bot for Peter Zijlstra
2010-04-02 19:07 ` [tip:perf/core] perf, x86: Fix AMD hotplug & constraint initialization tip-bot for Peter Zijlstra
2010-03-24 13:45 [PATCH] perf_events: fix bug in AMD per-cpu initialization Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269357506.5109.84.camel@twins \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome