mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: unlisted-recipients:; (no To-header on input)
Cc: Henrik Kretzschmar <henne@nachtwindheim.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Krzysztof Helt <krzysztof.h1@poczta.fm>,
	Arnaud Patard <arnaud.patard@rtp-net.org>,
	Andres Salomon <dilinger@debian.org>,
	Jaya Kumar <jayakumar.lkml@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Fix section mismatches in virtual framebuffer
Date: Wed, 24 Mar 2010 13:17:15 +0100	[thread overview]
Message-ID: <1269433035-6141-1-git-send-email-henne@nachtwindheim.de> (raw)

Both structs, vfb_default and vfb_fix, should not be freed,
since they are referenced and used by the struct fb_info of that device.

WARNING: drivers/video/vfb.o(.devinit.text+0x13f): Section mismatch in
reference from the function vfb_probe() to the variable
.init.data:vfb_default
The function __devinit vfb_probe() references
a variable __initdata vfb_default.
If vfb_default is only used by vfb_probe then
annotate vfb_default with a matching annotation.

WARNING: drivers/video/vfb.o(.devinit.text+0x162): Section mismatch in
reference from the function vfb_probe() to the variable
.init.data:vfb_fix
The function __devinit vfb_probe() references
a variable __initdata vfb_fix.
If vfb_fix is only used by vfb_probe then
annotate vfb_fix with a matching annotation.

WARNING: drivers/video/vfb.o(.devinit.text+0x177): Section mismatch in
reference from the function vfb_probe() to the variable
.init.data:vfb_fix
The function __devinit vfb_probe() references
a variable __initdata vfb_fix.
If vfb_fix is only used by vfb_probe then
annotate vfb_fix with a matching annotation.

WARNING: drivers/video/vfb.o(.devinit.text+0x184): Section mismatch in
reference from the function vfb_probe() to the (unknown reference)
.init.data:(unknown)
The function __devinit vfb_probe() references
a (unknown reference) __initdata (unknown).
If (unknown) is only used by vfb_probe then
annotate (unknown) with a matching annotation.

Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
 drivers/video/vfb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
index b8ab995..ae5796d 100644
--- a/drivers/video/vfb.c
+++ b/drivers/video/vfb.c
@@ -79,7 +79,7 @@ static void rvfree(void *mem, unsigned long size)
 	vfree(mem);
 }
 
-static struct fb_var_screeninfo vfb_default __initdata = {
+static struct fb_var_screeninfo vfb_default = {
 	.xres =		640,
 	.yres =		480,
 	.xres_virtual =	640,
@@ -101,7 +101,7 @@ static struct fb_var_screeninfo vfb_default __initdata = {
       	.vmode =	FB_VMODE_NONINTERLACED,
 };
 
-static struct fb_fix_screeninfo vfb_fix __initdata = {
+static struct fb_fix_screeninfo vfb_fix = {
 	.id =		"Virtual FB",
 	.type =		FB_TYPE_PACKED_PIXELS,
 	.visual =	FB_VISUAL_PSEUDOCOLOR,
-- 
1.6.3.3


             reply	other threads:[~2010-03-24 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 12:17 Henrik Kretzschmar [this message]
2010-03-26 17:40 ` Randy Dunlap
2010-03-26 21:37   ` Henrik Kretzschmar
2010-03-26 21:42     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269433035-6141-1-git-send-email-henne@nachtwindheim.de \
    --to=henne@nachtwindheim.de \
    --cc=akpm@linux-foundation.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=dilinger@debian.org \
    --cc=jayakumar.lkml@gmail.com \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®