From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932586Ab0CXSNM (ORCPT ); Wed, 24 Mar 2010 14:13:12 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:64797 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932496Ab0CXSNK (ORCPT ); Wed, 24 Mar 2010 14:13:10 -0400 X-Authority-Analysis: v=1.0 c=1 a=YPCQZwF6esMA:10 a=7U3hwN5JcxgA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=20KFwNOVAAAA:8 a=ZFEukxx33lFXTYUPXlUA:9 a=sTX1aeOc1SVI0UTWkjwja_Cr2kgA:4 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=jEp0ucaQiEUA:10 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.89.75 Subject: Re: [PATCH 1/2] Revert "rt: trivial fix to REMINDER block in init/main.c" From: Steven Rostedt Reply-To: rostedt@goodmis.org To: John Kacur Cc: Thomas Gleixner , lkml , rt-users , Clark Williams In-Reply-To: <1269452107-28655-2-git-send-email-jkacur@redhat.com> References: <1269452107-28655-1-git-send-email-jkacur@redhat.com> <1269452107-28655-2-git-send-email-jkacur@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Organization: Kihon Technologies Inc. Date: Wed, 24 Mar 2010 14:13:07 -0400 Message-ID: <1269454387.2957.2889.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-03-24 at 18:35 +0100, John Kacur wrote: > This reverts commit 3e39399ef4a742d994570488994be93ef17d4ef5. > > CONFIG_STACK_TRACER really should not be in the reminder block. > By default it is not enabled, and has negligible impact. Correct, the stack trace is based off of the function tracer, which with dynamic ftrace it does not have any extra impact when not enabled. Hmm, maybe we should add a warning if it was set on the command line? Anyway, Acked-by: Steven Rostedt -- Steve > > Signed-off-by: John Kacur > --- > init/main.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/init/main.c b/init/main.c > index 48393c0..aa48b7b 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -928,9 +928,6 @@ static int __init kernel_init(void * unused) > #ifdef CONFIG_PREEMPT_TRACER > printk(KERN_ERR "* CONFIG_PREEMPT_TRACER *\n"); > #endif > -#ifdef CONFIG_STACK_TRACER > - printk(KERN_ERR "* CONFIG_STACK_TRACER *\n"); > -#endif > #if defined(CONFIG_FTRACE) && !defined(CONFIG_FTRACE_MCOUNT_RECORD) > printk(KERN_ERR "* CONFIG_FTRACE *\n"); > #endif