From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Pekka J Enberg <penberg@cs.helsinki.fi>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: Potential stack overflow
Date: Wed, 24 Mar 2010 20:22:08 +0100 [thread overview]
Message-ID: <1269458528.2849.2.camel@edumazet-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1003241414270.14329@router.home>
Le mercredi 24 mars 2010 à 14:16 -0500, Christoph Lameter a écrit :
> On Wed, 24 Mar 2010, Eric Dumazet wrote:
>
> > I discovered that we can overflow stack if CONFIG_SLUB_DEBUG=y and use
> > slabs with many objects, since list_slab_objects() and process_slab()
> > use DECLARE_BITMAP(map, page->objects);
>
> Maybe we better allocate the bitmap via kmalloc then.
>
Hmm...
Are we allowed to nest in these two functions ?
GFP_KERNEL, GFP_ATOMIC ?
These are debugging functions, what happens if kmalloc() returns NULL ?
next prev parent reply other threads:[~2010-03-24 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 11:40 Eric Dumazet
2010-03-24 19:16 ` Christoph Lameter
2010-03-24 19:22 ` Eric Dumazet [this message]
2010-03-24 19:49 ` Christoph Lameter
2010-03-24 21:03 ` Eric Dumazet
2010-03-24 21:10 ` Christoph Lameter
2010-03-24 21:14 ` Christoph Lameter
2010-03-24 21:25 ` Eric Dumazet
2010-03-25 19:29 ` Pekka Enberg
2010-03-25 21:03 ` Christoph Lameter
2010-03-28 17:10 ` Pekka Enberg
2010-03-24 21:25 ` Christoph Lameter
2010-03-24 21:30 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269458528.2849.2.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®