From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: isdn@linux-pingi.de
Cc: davem@davemloft.net, linux@dominikbrodowski.net,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Henrik Kretzschmar <henne@nachtwindheim.de>
Subject: [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles
Date: Thu, 25 Mar 2010 13:05:30 +0100 [thread overview]
Message-ID: <1269518732-4515-2-git-send-email-henne@nachtwindheim.de> (raw)
In-Reply-To: <1269518732-4515-1-git-send-email-henne@nachtwindheim.de>
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.
WARNING: drivers/isdn/hisax/built-in.o(.text+0x56bfb): Section mismatch
in reference from the function teles_cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function teles_cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because teles_cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
drivers/isdn/hisax/teles_cs.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/hisax/teles_cs.c b/drivers/isdn/hisax/teles_cs.c
index b0c5976..d010a0d 100644
--- a/drivers/isdn/hisax/teles_cs.c
+++ b/drivers/isdn/hisax/teles_cs.c
@@ -57,7 +57,7 @@ module_param(protocol, int, 0);
handler.
*/
-static int teles_cs_config(struct pcmcia_device *link);
+static int teles_cs_config(struct pcmcia_device *link) __devinit ;
static void teles_cs_release(struct pcmcia_device *link);
/*
@@ -66,7 +66,7 @@ static void teles_cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/
-static void teles_detach(struct pcmcia_device *p_dev);
+static void teles_detach(struct pcmcia_device *p_dev) __devexit ;
/*
A linked list of "instances" of the teles_cs device. Each actual
@@ -112,7 +112,7 @@ typedef struct local_info_t {
======================================================================*/
-static int teles_probe(struct pcmcia_device *link)
+static int __devinit teles_probe(struct pcmcia_device *link)
{
local_info_t *local;
@@ -156,7 +156,7 @@ static int teles_probe(struct pcmcia_device *link)
======================================================================*/
-static void teles_detach(struct pcmcia_device *link)
+static void __devexit teles_detach(struct pcmcia_device *link)
{
local_info_t *info = link->priv;
@@ -200,7 +200,7 @@ static int teles_cs_configcheck(struct pcmcia_device *p_dev,
return -ENODEV;
}
-static int teles_cs_config(struct pcmcia_device *link)
+static int __devinit teles_cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
@@ -319,7 +319,7 @@ static struct pcmcia_driver teles_cs_driver = {
.name = "teles_cs",
},
.probe = teles_probe,
- .remove = teles_detach,
+ .remove = __devexit_p(teles_detach),
.id_table = teles_ids,
.suspend = teles_suspend,
.resume = teles_resume,
--
1.6.3.3
next prev parent reply other threads:[~2010-03-25 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
2010-03-25 12:05 ` Henrik Kretzschmar [this message]
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
2010-03-25 12:16 ` Karsten Keil
2010-03-25 12:15 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Karsten Keil
2010-03-25 12:14 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Karsten Keil
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
2010-03-25 17:02 ` Dominik Brodowski
2010-03-25 18:45 ` David Miller
2010-03-25 18:55 ` David Miller
2010-03-25 18:58 ` David Miller
2010-03-26 0:59 ` Henrik Kretzschmar
2010-03-26 3:27 ` David Miller
2010-03-26 13:56 ` Henrik Kretzschmar
2010-03-26 16:46 ` David Miller
2010-03-25 12:16 ` Wolfram Sang
2010-03-25 14:05 ` Henrik Kretzschmar
2010-03-25 14:17 ` Wolfram Sang
2010-03-25 14:08 ` Henrik Kretzschmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269518732-4515-2-git-send-email-henne@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®