From: Pavel Roskin <proski@gnu.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, Josh Triplett <josht@us.ibm.com>
Subject: [PATCH TRY2] locking: annotate inline spinlocks and rwlocks on SMP
Date: Thu, 25 Mar 2010 17:32:14 -0400 [thread overview]
Message-ID: <1269552734.2626.33.camel@mj> (raw)
Hello!
My patch at https://patchwork.kernel.org/patch/84441/ didn't get any
replies.
Bogus sparse warnings actually make developers change spin_lock() to
spin_lock_irqsave() to placate sparse, as it could be seen here:
http://marc.info/?l=linux-wireless&m=126954991321895&w=2
That's a patch I noticed because I read linux-wireless. I think it's a
safe bet that it's not the only patch inspired by the bogus sparse
warnings.
Locking is hard already, and we don't want sparse to confuse developers
even more. Linux code quality suffers because of that.
If there are any people or lists I should forward my patch to, please
let me know.
--
Regards,
Pavel Roskin
reply other threads:[~2010-03-25 21:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269552734.2626.33.camel@mj \
--to=proski@gnu.org \
--cc=josht@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®