From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: linux-fbdev@vger.kernel.org
Cc: "Henrik Kretzschmar" <henne@nachtwindheim.de>,
"Ferenc Bakonyi" <fero@drama.obuda.kando.hu>,
"Arnaud Patard" <arnaud.patard@rtp-net.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jaya Kumar" <jayakumar.lkml@gmail.com>,
"James Simmons" <jsimmons@infradead.org>,
linux-nvidia@lists.surfsouth.com, linux-kernel@vger.kernel.org
Subject: [PATCH 3/7] fbdev: section cleanup in hgafb
Date: Sat, 27 Mar 2010 07:29:07 +0100 [thread overview]
Message-ID: <1269671353-22041-2-git-send-email-henne@nachtwindheim.de> (raw)
In-Reply-To: <1269671353-22041-1-git-send-email-henne@nachtwindheim.de>
This patch cleans up the sections in the hgafb driver.
WARNING: drivers/video/hgafb.o(.devinit.text+0x18): Section mismatch in referenc
e from the function hgafb_probe() to the function .init.text:hga_card_detect()
The function __devinit hgafb_probe() references
a function __init hga_card_detect().
If hga_card_detect is only used by hgafb_probe then
annotate hga_card_detect with a matching annotation.
WARNING: drivers/video/hgafb.o(.devinit.text+0xfe): Section mismatch in referenc
e from the function hgafb_probe() to the variable .init.data:hga_fix
The function __devinit hgafb_probe() references
a variable __initdata hga_fix.
If hga_fix is only used by hgafb_probe then
annotate hga_fix with a matching annotation.
WARNING: drivers/video/hgafb.o(.devinit.text+0x105): Section mismatch in reference from the function hgafb_probe() to the variable .init.data:hga_default_var
The function __devinit hgafb_probe() references
a variable __initdata hga_default_var.
If hga_default_var is only used by hgafb_probe then
annotate hga_default_var with a matching annotation.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
drivers/video/hgafb.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c
index db9b785..234a6a5 100644
--- a/drivers/video/hgafb.c
+++ b/drivers/video/hgafb.c
@@ -107,7 +107,7 @@ static DEFINE_SPINLOCK(hga_reg_lock);
/* Framebuffer driver structures */
-static struct fb_var_screeninfo __initdata hga_default_var = {
+static struct fb_var_screeninfo hga_default_var __devinitdata = {
.xres = 720,
.yres = 348,
.xres_virtual = 720,
@@ -121,7 +121,7 @@ static struct fb_var_screeninfo __initdata hga_default_var = {
.width = -1,
};
-static struct fb_fix_screeninfo __initdata hga_fix = {
+static struct fb_fix_screeninfo hga_fix __devinitdata = {
.id = "HGA",
.type = FB_TYPE_PACKED_PIXELS, /* (not sure) */
.visual = FB_VISUAL_MONO10,
@@ -277,7 +277,7 @@ static void hga_blank(int blank_mode)
spin_unlock_irqrestore(&hga_reg_lock, flags);
}
-static int __init hga_card_detect(void)
+static int __devinit hga_card_detect(void)
{
int count = 0;
void __iomem *p, *q;
@@ -597,7 +597,7 @@ static int __devinit hgafb_probe(struct platform_device *pdev)
return 0;
}
-static int hgafb_remove(struct platform_device *pdev)
+static int __devexit hgafb_remove(struct platform_device *pdev)
{
struct fb_info *info = platform_get_drvdata(pdev);
@@ -622,7 +622,7 @@ static int hgafb_remove(struct platform_device *pdev)
static struct platform_driver hgafb_driver = {
.probe = hgafb_probe,
- .remove = hgafb_remove,
+ .remove = __devexit_p(hgafb_remove),
.driver = {
.name = "hgafb",
},
--
1.7.0
next prev parent reply other threads:[~2010-03-27 6:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 6:29 [PATCH 2/7] fbdev: section cleanup in efifb Henrik Kretzschmar
2010-03-27 6:29 ` Henrik Kretzschmar [this message]
2010-03-27 6:29 ` [PATCH 4/7] fbdev: section cleanup in vesafb Henrik Kretzschmar
2010-03-27 6:29 ` [PATCH 5/7] fbdev: section cleanup in vfb Henrik Kretzschmar
2010-03-27 6:29 ` [PATCH 6/7] fbdev: section cleanup in vga16fb Henrik Kretzschmar
2010-03-27 6:29 ` [PATCH 7/7] fbdev: section cleanup in w100fb Henrik Kretzschmar
2010-03-29 15:21 ` [PATCH 2/7] fbdev: section cleanup in efifb Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269671353-22041-2-git-send-email-henne@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=arnaud.patard@rtp-net.org \
--cc=fero@drama.obuda.kando.hu \
--cc=jayakumar.lkml@gmail.com \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®