From: Dave Airlie <airlied@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Dave Airlie <airlied@redhat.com>, David Howells <dhowells@redhat.com>
Subject: [PATCH] slow-work: use get_ref wrapper instead of directly calling get_ref
Date: Mon, 29 Mar 2010 16:51:42 +1000 [thread overview]
Message-ID: <1269845502-10163-1-git-send-email-airlied@redhat.com> (raw)
Otherwise we can get an oops if the user has no get_ref/put_ref
requirement.
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
kernel/slow-work.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/slow-work.c b/kernel/slow-work.c
index 7494bbf..7d3f4fa 100644
--- a/kernel/slow-work.c
+++ b/kernel/slow-work.c
@@ -637,7 +637,7 @@ int delayed_slow_work_enqueue(struct delayed_slow_work *dwork,
goto cancelled;
/* the timer holds a reference whilst it is pending */
- ret = work->ops->get_ref(work);
+ ret = slow_work_get_ref(work);
if (ret < 0)
goto cant_get_ref;
--
1.6.5.2
next reply other threads:[~2010-03-29 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 6:51 Dave Airlie [this message]
2010-03-29 11:01 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269845502-10163-1-git-send-email-airlied@redhat.com \
--to=airlied@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome