From: "Steven J. Magnani" <steve@digidescorp.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Sergey Temerkhanov <temerkhanov@cifronik.ru>,
microblaze-uclinux@itee.uq.edu.au,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] [RFC] Xilinx MPMC SDMA subsystem
Date: Mon, 29 Mar 2010 10:42:53 -0500 [thread overview]
Message-ID: <1269877373.6173.27.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <fa686aa41003261653j5a9be6e8gbe8f12e19a563cd6@mail.gmail.com>
On Fri, 2010-03-26 at 17:53 -0600, Grant Likely wrote:
> I've not got time to review this patch right now, but Sergey and
> Steven, you both posted MPMC drivers on the same day; Steven on the
> microblaze list and Sergey on the powerpc list. Can you two please
> coordinate and figure out how to mork toward a single driver that will
> meet both your needs? I don't want to have 2 drivers (3 if you count
> the ll_temac driver) in mainline for the same hardware interface.
>
I don't think we'll end up with a single driver. A MPMC DMA Engine
driver is useful only on "loopback" SDMA ports. Sergey's code looks like
a nice generic interface to Xilinx SDMA HW that could be used by the
xlldma and ll_temac drivers, for instance. Both of those will get
smaller, but won't go away.
For this to be useful to me, it would need to be located somewhere more
accessible than arch/powerpc and it would need to have initialization
methods that don't depend on OF. In my build I would have platform code
that binds to the xlldma platform attachment, which would call Sergey's
SDMA code to assign it the proper resources.
Any objections to having Sergey's code live in drivers/dma, and putting
sdma.h out in include/linux? Might need to tweak the file/function names
some to head off namespace issues. Or is there some other strategy for
managing Xilinx-related drivers common to both Microblaze and PowerPC?
Steve
next prev parent reply other threads:[~2010-03-29 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003172118.41559.temerkhanov@cifronik.ru>
2010-03-26 23:53 ` Grant Likely
2010-03-29 15:42 ` Steven J. Magnani [this message]
2010-03-29 15:56 ` Grant Likely
2010-03-29 19:04 ` Sergey Temerkhanov
2010-03-29 20:20 ` Grant Likely
2010-04-20 16:29 ` Steven J. Magnani
2010-04-27 16:09 ` Sergey Temerkhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269877373.6173.27.camel@iscandar.digidescorp.com \
--to=steve@digidescorp.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=temerkhanov@cifronik.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome