From: Joe Perches <joe@perches.com>
To: Alexander Kurz <akurz@blala.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Ken Kawasaki <ken_kawasaki@spring.nifty.jp>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Magnus Damm <damm@opensource.se>,
Ben Hutchings <ben@decadent.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() and friends (fwd)
Date: Tue, 30 Mar 2010 10:22:13 -0700 [thread overview]
Message-ID: <1269969733.4558.171.camel@Joe-Laptop.home> (raw)
In-Reply-To: <alpine.DEB.1.10.1003302019200.11637@blala.de>
On Tue, 2010-03-30 at 21:01 +0400, Alexander Kurz wrote:
> I wrote a patch as suggested by kernel-janitors.
> It is my first patch, so I highly welcome comments and hints,
> thanks, Alexander Kurz
As this is a network driver, you could use netdev_<level>
for most of this. Also, you could coalesce the format
strings to go beyond 80 columns. It makes grepping
a bit easier.
> - printk(KERN_INFO "%s: %s at io %#3lx, irq %d, "
> + dev_info(&dev->dev, "%s: %s at io %#3lx, irq %d, "
> "hw_addr %pM.\n",
This could become:
netdev_info(dev, "%s at io %#3lx, irq %d, hw_addr %pM\n"
cardname, dev->base_addr, dev->irq, dev->dev_addr);
etc.
next prev parent reply other threads:[~2010-03-30 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 17:01 Alexander Kurz
2010-03-30 17:22 ` Joe Perches [this message]
2010-03-31 12:42 ` [PATCH] net/pcmcia/3c589_cs: using netdev_info and friends where appropriate linux
2010-04-02 2:54 ` David Miller
2010-03-31 7:05 ` [PATCH] net/pcmcia 3com: replacements of printk() with dev_info() and friends (fwd) Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269969733.4558.171.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akurz@blala.de \
--cc=ben@decadent.org.uk \
--cc=damm@opensource.se \
--cc=davem@davemloft.net \
--cc=ken_kawasaki@spring.nifty.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®